From: "cron2 (Code Review)" Date: Wed, 30 Jul 2025 18:04:15 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="TO6lX3dNom8="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix broken DHCP options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: plaisthos , flichtenheld , openvpn-devel --TO6lX3dNom8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1090?usp=3Demail ) Change subject: Fix broken DHCP options ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: This plays together with the code in tun.c that checks whether or not the T= AP driver needs to be informed about DHCP options ``` /* user-supplied DHCP options capability */ if (tt->options.dhcp_options) { .. if (!DeviceIoControl(tt->hand, TAP_WIN_IOCTL_CONFIG_DHCP_SET_OP= T, .. ``` ... so if we no longer flag these "it can be done with DHCP or not" options= as "well, if we have DHCP, we should set them!" (DHCP_OPTIONS_DHCP_OPTIONA= L), and we have no "this can only be done with DHCP!" options (DHCP_OPTIONS= _DHCP_REQUIRED), then tun.c just assumes "well, nothing required, nothing t= o set up" and DNS will not work. I experienced the issue myself with 2.7_alpha2 and a setup that ended up us= ing TAP and DHCP, and the explanation makes sense. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1090?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0d75efcceb826d06e74abd003d5377468ff9fe3b Gerrit-Change-Number: 1090 Gerrit-PatchSet: 1 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Wed, 30 Jul 2025 18:04:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --TO6lX3dNom8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

Patch set 1:Code-Review +2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      This plays together with the code in tun.c t= hat checks whether or not the TAP driver needs to be informed about DHCP op= tions

      ```
      /* user-supplied DHCP options capability */
      if (tt-= >options.dhcp_options)
      {
      ..
      if (!DeviceIoContro= l(tt->hand, TAP_WIN_IOCTL_CONFIG_DHCP_SET_OPT,
      ..
      ```

      ... so if we no longer = flag these "it can be done with DHCP or not" options as "wel= l, if we have DHCP, we should set them!" (DHCP_OPTIONS_DHCP_OPTIONAL),= and we have no "this can only be done with DHCP!" options (DHCP_= OPTIONS_DHCP_REQUIRED), then tun.c just assumes "well, nothing require= d, nothing to set up" and DNS will not work.

      I experienced the issue myself with 2.= 7_alpha2 and a setup that ended up using TAP and DHCP, and the explanation = makes sense.

To view, visit change 1090. To unsubscri= be, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0d75efcceb826d06e74abd003d5= 377468ff9fe3b
Gerrit-Change-Number: 1090
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Wed, 30 Jul 2025 18:04:15= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--TO6lX3dNom8=--