Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA5A4C4332F for ; Wed, 4 Jan 2023 17:24:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0902B8551E; Wed, 4 Jan 2023 18:24:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="e44NcQF1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CE08F851BC; Wed, 4 Jan 2023 18:24:19 +0100 (CET) Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 03E968551E for ; Wed, 4 Jan 2023 18:24:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-yb1-xb34.google.com with SMTP id l139so3024042ybl.12 for ; Wed, 04 Jan 2023 09:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=opLszNNmWgSht4A3E0dV+o8awjsZg0BU38Xx1EZn7WM=; b=e44NcQF1fwdM81ZQDQO7PgcWAEZxE29OCeS1MqctF5BxHMc7pXZrcpCmI3U5871Pdh 4mn1sSUQsB+esWbwAa6O+zRam+GbZFYSqJcRitu98IeByIXY6uIeL374ScAxtwLRGtp1 z5NHNpzE0+e+SHzaaVr9rDK8Q5Q7gO9ae6oT20XBYCXGnhYQJGuIfZJg1391Ru85Xtld Hf9YlplMlzJ5Ev7sWjwDQzZovThsmhtUpjPOQatcTYubnxTmSWNj7pkZ6hZs1r9ncY3c w1zd0FGGcxlahoBZzH5ZYgFV8lLL8evyzLOKvTzZv2mZyqHBIQaDfIaerVekn78ntz5P yOcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opLszNNmWgSht4A3E0dV+o8awjsZg0BU38Xx1EZn7WM=; b=xIurvlswEW/UcKG6smOGmmia707O7jkG26oWCIGfN3tLk5T5d0hw/Sa3IU0Lga2BN2 3FfIzgxAbL2/q7b6I1xN+tJ/qeYaKhBT+qgNFFg61YXfEL682kwXh0NkRut8Ot5ZgUWP M6umTM+wIywz+hGqb3dfzpCb0e1pOzkGy22aJqrDLqxxR7xJ3F6tz50zF9FnQOicPBft 8G59eHGcLhItsbwrZdh7uSLekFLkXADWqBBt+BqJvTFiIdUTr1+cXCZbHu7PUru4xC7G z2s2mCuVyrm9/lRJB3DBbcfrVHliu2ICFDXQu+k6kwXGfrHyOOAv9GfWcvQHJCuLrTBu /2+A== X-Gm-Message-State: AFqh2ko2j7QxR43nD4g0kZrfK8aJc2XIBM+42mEkksCAHzWGMdmgodzV PYULTZbwfsDRSw/s/xFdvaNmDTra4gs= X-Google-Smtp-Source: AMrXdXtiZ2O/MuzRTGiKpDZcgR2Wmywqu/z8VPiH8GxuA9+D6zHt3Rf9RYukkpju/RCgbXYqPGkXSw== X-Received: by 2002:a25:4dd4:0:b0:7b2:ee4e:c437 with SMTP id a203-20020a254dd4000000b007b2ee4ec437mr1422671ybb.23.1672853054783; Wed, 04 Jan 2023 09:24:14 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id t1-20020a37ea01000000b006fefa5f7fcesm24429853qkj.10.2023.01.04.09.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 09:24:14 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 12:24:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] reset: Allow reset_get_by_name() with NULL name Content-Language: en-US To: Samuel Holland , Lukasz Majewski Cc: u-boot@lists.denx.de, Alexander Dahl , Marek Vasut , Simon Glass References: <20221128055359.35762-1-samuel@sholland.org> <20221128055359.35762-2-samuel@sholland.org> From: Sean Anderson In-Reply-To: <20221128055359.35762-2-samuel@sholland.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/28/22 00:53, Samuel Holland wrote: > This allows devm_reset_control_get(dev, NULL) to work and get the first > reset control, which is common in code ported from Linux. > > Signed-off-by: Samuel Holland > --- > > drivers/reset/reset-uclass.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c > index bcef46039c2..a26c623a77e 100644 > --- a/drivers/reset/reset-uclass.c > +++ b/drivers/reset/reset-uclass.c > @@ -147,13 +147,14 @@ int reset_get_bulk(struct udevice *dev, struct reset_ctl_bulk *bulk) > int reset_get_by_name(struct udevice *dev, const char *name, > struct reset_ctl *reset_ctl) > { > - int index; > + int index = 0; > > debug("%s(dev=%p, name=%s, reset_ctl=%p)\n", __func__, dev, name, > reset_ctl); > reset_ctl->dev = NULL; > > - index = dev_read_stringlist_search(dev, "reset-names", name); > + if (name) > + index = dev_read_stringlist_search(dev, "reset-names", name); > if (index < 0) { > debug("fdt_stringlist_search() failed: %d\n", index); > return index; Reviewed-by: Sean Anderson