From: Mahesh Kumar Subject: Re: [PATCH 3/8] drm/i915: Use new atomic helpers in intel_plane_atomic_check Date: Tue, 1 Aug 2017 13:27:04 +0530 Message-ID: References: <20170720131519.30104-1-maarten.lankhorst@linux.intel.com> <20170720131519.30104-4-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C8A36EA9C for ; Tue, 1 Aug 2017 07:52:55 +0000 (UTC) In-Reply-To: <20170720131519.30104-4-maarten.lankhorst@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGksCgoKT24gVGh1cnNkYXkgMjAgSnVseSAyMDE3IDA2OjQ1IFBNLCBNYWFydGVuIExhbmtob3Jz dCB3cm90ZToKPiBSZW1vdmUgdGhlIHVzZSBvZiBwbGFuZS0+c3RhdGUgYW5kIGRybV9hdG9taWNf Z2V0X2V4aXN0aW5nX3N0YXRlLAo+IGluc3RlYWQgdXNlIHRoZSBuZXcgaGVscGVycywgYW5kIGFs c28gYWRkCj4gaW50ZWxfYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZSBhcyBpdCdzIG5lZWRlZC4K Pgo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBs aW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9t aWNfcGxhbmUuYyB8IDIyICsrKysrKysrKysrKystLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oICAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysKPiAgIDIgZmls ZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gaW5kZXggZWU3NmZhYjdiYjZmLi4x MDgxZDBiNjNiNmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRv bWljX3BsYW5lLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxh bmUuYwo+IEBAIC0xOTgsMTIgKzE5OCwxNyBAQCBpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNr X3dpdGhfc3RhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gICB9Cj4g ICAKPiAgIHN0YXRpYyBpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lLAo+IC0JCQkJICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ICsJ CQkJICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm5ld19wbGFuZV9zdGF0ZSkKPiAgIHsKPiAt CXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IHN0YXRlLT5jcnRjOwo+IC0Jc3RydWN0IGRybV9jcnRj X3N0YXRlICpkcm1fY3J0Y19zdGF0ZTsKPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZSA9IG5ld19wbGFuZV9zdGF0ZS0+c3RhdGU7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YzsK PiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZTsKPiArCXN0cnVjdCBk cm1fcGxhbmVfc3RhdGUgKm9sZF9wbGFuZV9zdGF0ZTsKPiArCXN0cnVjdCBpbnRlbF9wbGFuZV9z dGF0ZSAqbmV3X2ludGVsX3BsYW5lX3N0YXRlOwo+ICAgCj4gLQljcnRjID0gY3J0YyA/IGNydGMg OiBwbGFuZS0+c3RhdGUtPmNydGM7Cj4gKwlvbGRfcGxhbmVfc3RhdGUgPSBkcm1fYXRvbWljX2dl dF9vbGRfcGxhbmVfc3RhdGUoc3RhdGUsIHBsYW5lKTsKPiArCj4gKwljcnRjID0gdG9faW50ZWxf Y3J0YyhuZXdfcGxhbmVfc3RhdGUtPmNydGMgPzogb2xkX3BsYW5lX3N0YXRlLT5jcnRjKTsKPiAg IAo+ICAgCS8qCj4gICAJICogQm90aCBjcnRjIGFuZCBwbGFuZS0+Y3J0YyBjb3VsZCBiZSBOVUxM IGlmIHdlJ3JlIHVwZGF0aW5nIGEKeW91IG1heSB3YW50IHRvIHVwZGF0ZSBjb21tZW50IGFzIHdl bGwgZm9yIGJldHRlciB1bmRlcnN0YW5kaW5nLiA6KQo+IEBAIC0yMTQsMTIgKzIxOSwxMSBAQCBz dGF0aWMgaW50IGludGVsX3BsYW5lX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFu ZSwKPiAgIAlpZiAoIWNydGMpCj4gICAJCXJldHVybiAwOwo+ICAgCj4gLQlkcm1fY3J0Y19zdGF0 ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3RhdGUtPnN0YXRlLCBjcnRj KTsKPiAtCWlmIChXQVJOX09OKCFkcm1fY3J0Y19zdGF0ZSkpCj4gLQkJcmV0dXJuIC1FSU5WQUw7 Cj4gKwluZXdfY3J0Y19zdGF0ZSA9IGludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3Rh dGUsIGNydGMpOwo+ICsJbmV3X2ludGVsX3BsYW5lX3N0YXRlID0gdG9faW50ZWxfcGxhbmVfc3Rh dGUobmV3X3BsYW5lX3N0YXRlKTsKPiAgIAo+IC0JcmV0dXJuIGludGVsX3BsYW5lX2F0b21pY19j aGVja193aXRoX3N0YXRlKHRvX2ludGVsX2NydGNfc3RhdGUoZHJtX2NydGNfc3RhdGUpLAo+IC0J CQkJCQkgICB0b19pbnRlbF9wbGFuZV9zdGF0ZShzdGF0ZSkpOwo+ICsJcmV0dXJuIGludGVsX3Bs YW5lX2F0b21pY19jaGVja193aXRoX3N0YXRlKG5ld19jcnRjX3N0YXRlLAo+ICsJCQkJCQkgICBu ZXdfaW50ZWxfcGxhbmVfc3RhdGUpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZCBpbnRlbF9w bGFuZV9hdG9taWNfdXBkYXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gaW5kZXggMzcyM2VlNDQzZmFhLi45ODg1MWVkNWVjMmIgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC0xOTU3LDYgKzE5NTcsMjAgQEAgaW50ZWxfYXRv bWljX2dldF9vbGRfY3J0Y19zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4g ICAJCXJldHVybiBOVUxMOwo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGludGVs X2NydGNfc3RhdGUgKgo+ICtpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ ICt7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwo+ICsJY3J0Y19z dGF0ZSA9IGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0YXRlLCAmY3J0Yy0+YmFzZSk7 Cj4gKwo+ICsJaWYgKGNydGNfc3RhdGUpCj4gKwkJcmV0dXJuIHRvX2ludGVsX2NydGNfc3RhdGUo Y3J0Y19zdGF0ZSk7Cj4gKwllbHNlCj4gKwkJcmV0dXJuIE5VTEw7Cj4gK30KPiArCldpdGggcHJl dmlvdXMgcGF0Y2ggY29tbWVudCBhZGRyZXNzZWQsIFRoaXMgd3JhcHBlciB3aWxsIGJlIGFscmVh ZHkgCmF2YWlsYWJsZS4Kb3RoZXJ3aXNlIHBhdGNoIGxvb2tzIG9rIHRvIG1lLgoKLU1haGVzaAo+ ICAgc3RhdGljIGlubGluZSBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKgo+ICAgaW50ZWxfYXRv bWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ ICAgCQkJCSAgICAgIHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUpCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK