Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D544FC00140 for ; Wed, 10 Aug 2022 12:07:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbiHJMH7 (ORCPT ); Wed, 10 Aug 2022 08:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbiHJMH6 (ORCPT ); Wed, 10 Aug 2022 08:07:58 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AFC013D59 for ; Wed, 10 Aug 2022 05:07:54 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 73BAB221D4; Wed, 10 Aug 2022 14:07:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1660133272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+IAqyaBmdCqar9LA4rA4MEkwkKAIVuGKn7A+r+hkxyY=; b=t1pGvNdp/hT/8P5hIqAzHLf1EN9jMaWYhRzF54ep93oeVMNu4nnqWghKmb7G+oYHRfIwmg gpzBI5c+/BP1qmp1E934lvZs8kOmjiglXNxAfe82dBjPwcl1mwPOdklUqPt0t8yRlEyLQ7 w/X6T6R8uchdVoEE4AcM/FkgN55v8Do= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 Aug 2022 14:07:52 +0200 From: Michael Walle To: Ajay.Kathat@microchip.com Cc: linux-wireless@vger.kernel.org, Claudiu.Beznea@microchip.com, Sripad.Balwadgi@microchip.com, mwalle@kernel.org Subject: Re: [PATCH v3] wifi: wilc1000: fix DMA on stack objects In-Reply-To: <20220809075749.62752-1-ajay.kathat@microchip.com> References: <20220809075749.62752-1-ajay.kathat@microchip.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Am 2022-08-09 09:57, schrieb Ajay.Kathat@microchip.com: > Sometimes 'wilc_sdio_cmd53' is called with addresses pointing to an > object on the stack. Use dynamically allocated memory for cmd53 instead > of stack address which is not DMA'able. > > Fixes: 5625f965d764 ("wilc1000: move wilc driver out of staging") > Reported-by: Michael Walle > Suggested-by: Michael Walle > Signed-off-by: Ajay Singh Thanks! Reviewed-by: Michael Walle Tested-by: Michael Walle -michael