From: "mandree (Code Review)" Date: Tue, 16 Dec 2025 19:41:00 +0000 In-Reply-To: References: Reply-To: matthias.andree@...68..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="4d78RaVYdgA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: ssl_verify_openssl: Avoid conversion warning in x509_verify_cert_ku List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --4d78RaVYdgA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. mandree has posted comments on this change by flichtenheld. ( http://gerrit= .openvpn.net/c/openvpn/+/1445?usp=3Demail ) Change subject: ssl_verify_openssl: Avoid conversion warning in x509_verify= _cert_ku ...................................................................... Patch Set 1: Code-Review-2 (5 comments) Patchset: PS1: I think the fixes go in the wrong direction. File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1445/comment/821e73fa_f775f9c3?usp=3D= email : PS1, Line 678: x509_verify_cert_ku(X509 *x509, const unsigned *const expect= ed_ku, int expected_len) expected_len might be an unsigned int or size_t to fix warnings below. http://gerrit.openvpn.net/c/openvpn/+/1445/comment/d6e1387e_3213e9eb?usp=3D= email : PS1, Line 696: for (int i =3D 0; i < 8; i++) I don't seem to have the ASN1_BIT_STRING_get_bit() manpage handy, but if th= e compiler is unhappy about the nku |=3D line, make the literals unsigned, = as in nku |=3D 1u << (7u - i) while i is some unsigned type (such as size_t= ). http://gerrit.openvpn.net/c/openvpn/+/1445/comment/253f9ee2_e2908373?usp=3D= email : PS1, Line 714: for (int i =3D 0; fFound !=3D SUCCESS && i < expected_le= n; i++) If this triggers a signed/unsigned mismatch on the < - that's because the i= terator was a size_t and the expected_len argument a signed plain "int". http://gerrit.openvpn.net/c/openvpn/+/1445/comment/360f53ad_26945225?usp=3D= email : PS1, Line 725: for (int i =3D 0; i < expected_len && expected_ku[i]= ; i++) If this triggers a signed/unsigned mismatch on the < - that's because the i= terator was a size_t and the expected_len argument a signed plain "int". -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1445?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia6c3f0395bd6cd67064fe77420d9df2b66763049 Gerrit-Change-Number: 1445 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: mandree Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 16 Dec 2025 19:41:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --4d78RaVYdgA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 1:Code-Review -2=

V= iew Change

5 comments:

To view, visit change 1445. To unsubscribe, or for help writing mail= filters, visit = settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c3f0395bd6cd67064fe77420d= 9df2b66763049
Gerrit-Change-Number: 1445
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: mandree <matthias.andree@...220...= ..68...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 16 Dec 2025 19:41:00= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --4d78RaVYdgA=--