From: "cron2 (Code Review)" Date: Tue, 14 Apr 2026 16:43:29 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="yuW+LYiWxfw="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: ssl_mbedtls: Fix format string in get_ssl_library_version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --yuW+LYiWxfw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1626?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: ssl_mbedtls: Fix format string in get_ssl_library_version ...................................................................... ssl_mbedtls: Fix format string in get_ssl_library_version These are unsigned values, so treat them as such. Identified by cppcheck. Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1626 Message-Id: <20260414055927.17252-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 607.html Signed-off-by: Gert Doering --- M src/openvpn/ssl_mbedtls.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/1626/2 diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index a62ff76..85c771a 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1572,7 +1572,7 @@ { static char mbedtls_version[30]; unsigned int pv =3D mbedtls_version_get_number(); - snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d"= , (pv >> 24) & 0xff, + snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %u.%u.%u"= , (pv >> 24) & 0xff, (pv >> 16) & 0xff, (pv >> 8) & 0xff); return mbedtls_version; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1626?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Gerrit-Change-Number: 1626 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --yuW+LYiWxfw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by plaisthos

ssl_mbedtls: Fix format string =
in get_ssl_library_version

These are unsigned values, so treat them = as such.

Identified by cppcheck.

Change-Id: I232fba91cfcca6c3= 5d37696bc86890a366f5967f
Signed-off-by: Frank Lichtenheld <frank@...1665...= 641...>
Acked-by: Arne Schwabe <arne-openvpn@...1227...>
Ger= rit URL: https://gerrit.openvpn.net/c/openvpn/+/1626
Message-Id: <202= 60414055927.17252-1-gert@...1296...>
URL: https://www.mail-archive.co= m/openvpn-devel@lists.sourceforge.net/msg36607.html
Signed-off-by: Gert = Doering <gert@...1296...>
---
M src/openvpn/ssl_mbedtls.c
1 = file changed, 1 insertion(+), 1 deletion(-)

git =
pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/1626/2
= diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.cindex a62ff76..85c771a 100644
--- a/src/openvpn/ssl= _mbedtls.c
+++ b/src/openvpn/ssl_mbedtls.c
= @@ -1572,7 +1572,7 @@
{
static char m= bedtls_version[30];
unsigned int pv =3D mbedtls_versio= n_get_number();
- sn= printf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d&qu= ot;, (pv >> 24) & 0xff,
+ snprintf(mbedtls_version, sizeof(mbedtls_version), "= mbed TLS %u.%u.%u", (pv >> 24) & 0xff,
= (pv >> 16) & 0xff, (pv >> 8) & 0xff); return mbedtls_version;
}

To view, visit change 1626. To unsubscribe, or for help writin= g mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I232fba91cfcca6c35d37696bc86= 890a366f5967f
Gerrit-Change-Number: 1626
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --yuW+LYiWxfw=--