From: "cron2 (Code Review)" Date: Tue, 14 Apr 2026 16:43:31 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="gDY6cg58jUg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: ssl_mbedtls: Fix format string in get_ssl_library_version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --gDY6cg58jUg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/16= 26?usp=3Demail ) Change subject: ssl_mbedtls: Fix format string in get_ssl_library_version ...................................................................... ssl_mbedtls: Fix format string in get_ssl_library_version These are unsigned values, so treat them as such. Identified by cppcheck. Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1626 Message-Id: <20260414055927.17252-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 607.html Signed-off-by: Gert Doering --- M src/openvpn/ssl_mbedtls.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index a62ff76..85c771a 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1572,7 +1572,7 @@ { static char mbedtls_version[30]; unsigned int pv =3D mbedtls_version_get_number(); - snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d"= , (pv >> 24) & 0xff, + snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %u.%u.%u"= , (pv >> 24) & 0xff, (pv >> 16) & 0xff, (pv >> 8) & 0xff); return mbedtls_version; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1626?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Gerrit-Change-Number: 1626 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --gDY6cg58jUg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

ssl_mbedtls: Fix format string in get_ssl_librar=
y_version

These are unsigned values, so treat them as such.

I= dentified by cppcheck.

Change-Id: I232fba91cfcca6c35d37696bc86890a36= 6f5967f
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Ack= ed-by: Arne Schwabe <arne-openvpn@...1227...>
Gerrit URL: https://= gerrit.openvpn.net/c/openvpn/+/1626
Message-Id: <20260414055927.17252= -1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...465...= ists.sourceforge.net/msg36607.html
Signed-off-by: Gert Doering <gert@= ...1296...>
---
M src/openvpn/ssl_mbedtls.c
1 file changed, 1 i= nsertion(+), 1 deletion(-)

diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c
index a62ff76..85c771a 100644
--- a/src/openvpn/= ssl_mbedtls.c
+++ b/src/openvpn/ssl_mbedtls.c
@@ -1572,7 +1572,7 @@
{
static cha= r mbedtls_version[30];
unsigned int pv =3D mbedtls_ver= sion_get_number();
- = snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d= ", (pv >> 24) & 0xff,
+ snprintf(mbedtls_version, sizeof(mbedtls_version), &qu= ot;mbed TLS %u.%u.%u", (pv >> 24) & 0xff,
= (pv >> 16) & 0xff, (pv >> 8) & 0xff);
return mbedtls_version;
}
=

To view, visit change 1626. To unsubscribe, or for help wri= ting mail filters, visit settings.

=
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I232fba91cfcca6c35d37696bc86= 890a366f5967f
Gerrit-Change-Number: 1626
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --gDY6cg58jUg=--