From: Tvrtko Ursulin Subject: Re: [RFC 2/4] drm/i915/pmu: Convert engine sampling to uncore mmio Date: Thu, 1 Aug 2019 13:03:48 +0100 Message-ID: References: <20190801101825.2784-1-tvrtko.ursulin@linux.intel.com> <20190801101825.2784-3-tvrtko.ursulin@linux.intel.com> <156465558692.2512.16294533985029116986@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C81BB6E580 for ; Thu, 1 Aug 2019 12:03:50 +0000 (UTC) In-Reply-To: <156465558692.2512.16294533985029116986@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzA4LzIwMTkgMTE6MzMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA4LTAxIDExOjE4OjIzKQo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBEcm9wcyBvbmUgbWFjcm8gdXNpbmcgaW1w bGljaXQgZGV2X3ByaXYuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcG11LmMgfCAyMyArKysrKysrKysrKysrLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2Vk LCAxMyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3BtdS5jCj4+IGluZGV4IDEyMDA4OTY2YjAwZS4uYmQ5YWQ0ZjJiNGU0IDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcG11LmMKPj4gQEAgLTE2MiwyOSArMTYyLDMwIEBAIGFkZF9zYW1wbGUoc3Ry dWN0IGk5MTVfcG11X3NhbXBsZSAqc2FtcGxlLCB1MzIgdmFsKQo+PiAgIH0KPj4gICAKPj4gICBz dGF0aWMgdm9pZAo+PiAtZW5naW5lc19zYW1wbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LCB1bnNpZ25lZCBpbnQgcGVyaW9kX25zKQo+PiArZW5naW5lc19zYW1wbGUoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIHVuc2lnbmVkIGludCBwZXJpb2RfbnMpCj4+ICAgewo+ PiArICAgICAgIHN0cnVjdCBpbnRlbF91bmNvcmUgKnVuY29yZSA9ICZpOTE1LT51bmNvcmU7Cj4+ ICAgICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPj4gICAgICAgICAgZW51 bSBpbnRlbF9lbmdpbmVfaWQgaWQ7Cj4+ICAgICAgICAgIGludGVsX3dha2VyZWZfdCB3YWtlcmVm Owo+PiAgICAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+PiAgIAo+PiAtICAgICAgIGlmICgo ZGV2X3ByaXYtPnBtdS5lbmFibGUgJiBFTkdJTkVfU0FNUExFX01BU0spID09IDApCj4+ICsgICAg ICAgaWYgKChpOTE1LT5wbXUuZW5hYmxlICYgRU5HSU5FX1NBTVBMRV9NQVNLKSA9PSAwKQo+PiAg ICAgICAgICAgICAgICAgIHJldHVybjsKPj4gICAKPj4gICAgICAgICAgd2FrZXJlZiA9IDA7Cj4+ IC0gICAgICAgaWYgKFJFQURfT05DRShkZXZfcHJpdi0+Z3QuYXdha2UpKQo+PiAtICAgICAgICAg ICAgICAgd2FrZXJlZiA9IGludGVsX3J1bnRpbWVfcG1fZ2V0X2lmX2luX3VzZSgmZGV2X3ByaXYt PnJ1bnRpbWVfcG0pOwo+PiArICAgICAgIGlmIChSRUFEX09OQ0UoaTkxNS0+Z3QuYXdha2UpKQo+ PiArICAgICAgICAgICAgICAgd2FrZXJlZiA9IGludGVsX3J1bnRpbWVfcG1fZ2V0X2lmX2luX3Vz ZSgmaTkxNS0+cnVudGltZV9wbSk7Cj4+ICAgICAgICAgIGlmICghd2FrZXJlZikKPj4gICAgICAg ICAgICAgICAgICByZXR1cm47Cj4+ICAgCj4+IC0gICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmRl dl9wcml2LT51bmNvcmUubG9jaywgZmxhZ3MpOwo+PiAtICAgICAgIGZvcl9lYWNoX2VuZ2luZShl bmdpbmUsIGRldl9wcml2LCBpZCkgewo+PiArICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZ1bmNv cmUtPmxvY2ssIGZsYWdzKTsKPj4gKyAgICAgICBmb3JfZWFjaF9lbmdpbmUoZW5naW5lLCBpOTE1 LCBpZCkgewo+PiAgICAgICAgICAgICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfcG11ICpwbXUg PSAmZW5naW5lLT5wbXU7Cj4+ICAgICAgICAgICAgICAgICAgYm9vbCBidXN5Owo+PiAgICAgICAg ICAgICAgICAgIHUzMiB2YWw7Cj4+ICAgCj4+IC0gICAgICAgICAgICAgICB2YWwgPSBJOTE1X1JF QURfRlcoUklOR19DVEwoZW5naW5lLT5tbWlvX2Jhc2UpKTsKPj4gKyAgICAgICAgICAgICAgIHZh bCA9IGludGVsX3VuY29yZV9yZWFkX2Z3KHVuY29yZSwgUklOR19DVEwoZW5naW5lLT5tbWlvX2Jh c2UpKTsKPiAKPiBDb3VsZCB1c2UgRU5HSU5FX1JFQURfRlcoZW5naW5lLCBSSU5HX0NUTCkgPwoK RC1vaCEKCj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgoKVGhhbmtzIQoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZng=