Message-ID: Date: Wed, 7 Dec 2022 13:25:26 +0100 MIME-Version: 1.0 References: <20221207100201.6467-1-a@...2181...> Content-Language: en-GB From: Arne Schwabe In-Reply-To: <20221207100201.6467-1-a@...2181...> Subject: Re: [Openvpn-devel] [PATCH] disable DCO if --secret is specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Antonio Quartulli , openvpn-devel@lists.sourceforge.net Am 07.12.22 um 11:02 schrieb Antonio Quartulli: > P2P mode with pre-shared key is deprecated, unsecure and should NOT be > used. This said we still carry it around for a bit and we have to make > sure it does not fights with DCO. > > Disable DCO at all when --secret is specified. > > Signed-off-by: Antonio Quartulli > --- > src/openvpn/dco.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c > index d599dd7e..1cd698bf 100644 > --- a/src/openvpn/dco.c > +++ b/src/openvpn/dco.c > @@ -274,6 +274,12 @@ dco_check_startup_option(int msglevel, const struct options *o) > return false; > } > > + if (o->shared_secret_file) > + { > + msg(msglevel, "--secret is set. Disabling data channel offload"); > + return false; > + } I think you missing the mode when you have neither --secret nor any of the tls modes. Arne