Received: from eggs.gnu.org ([209.51.188.92]:41163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDlvs-0003YW-Vb for qemu-devel@nongnu.org; Tue, 09 Apr 2019 04:16:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDlvs-0006YE-3g for qemu-devel@nongnu.org; Tue, 09 Apr 2019 04:16:40 -0400 References: <9409d9bf-c513-d82b-d438-9173fc582d7f@redhat.com> <87mukzei52.fsf@dusky.pond.sub.org> From: Thomas Huth Message-ID: Date: Tue, 9 Apr 2019 10:16:33 +0200 MIME-Version: 1.0 In-Reply-To: <87mukzei52.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Stephen Checkoway , qemu-devel@nongnu.org, Kevin Wolf , Stephen Checkoway , qemu-block@nongnu.org, Laurent Vivier , Max Reitz , Paolo Bonzini On 09/04/2019 09.45, Markus Armbruster wrote: > Thomas Huth writes: >=20 >> We'd like to get rid of global_qtest in the long run (since it is >> causing trouble for tests that run multiple instances of QEMU in >> parallel, e.g. migration tests)... so if it is feasible, please don't >> use it in new code anymore. Try to use a local variable in the functio= n >> that call qtest_initf() and pass the test state around via a parameter >> to the functions that need it. >=20 > Twenty tests still use @global_qtest >=20 > Either we're serious about getting rid of @global_qtest. Then we shoul= d > just do it. Ha ha, "just do it" ... that's quite a bit of work, actually. It's not just about grep'ing for global_qtest, you also have to replace all the writel(), readl() etc. functions with qtest_writel(), qtest_readl() etc. If you feel like this is a "just do it" quick task, you're welcome to hel= p! > Or we're not. Then we shouldn't ask contributors to do extra work. We are: git log --oneline -- tests | grep global_qtest ... it just takes time. Thomas