Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C26E6C4332F for ; Wed, 4 Jan 2023 17:49:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C32718551E; Wed, 4 Jan 2023 18:49:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jWBANbVb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A55328551E; Wed, 4 Jan 2023 18:49:32 +0100 (CET) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BB80585523 for ; Wed, 4 Jan 2023 18:49:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf34.google.com with SMTP id i12so23936305qvs.2 for ; Wed, 04 Jan 2023 09:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fuiIySm4c6+eg7s6v2OeYyG0eBFO5EIu7Ww/Zdpp2HM=; b=jWBANbVbWzA+ap1JZHywWw36eYaPKmyh0Uvb96IagCkCizO6y5bhgQD6gMDqv/GNIS S7p3772tvx8Polx0/m7XFzGVtDBePmo/EDlXCcPLV2A9Fy6QWFS2WcvdEbWCU3NoxMOS AKK1K0UgWuUPgaoN+rcoURGmV0FTEHnoJh6mxgc2AmmrreZI480JSpM2IR481qdvYymW P7LHUduoGo3U/Hbe+XwSrVMSTcpca4nT5jcsJ4zwETf7WP7T3hBRsALr4PFgjyznSw/T akTudLQidczWzDnz7lkexYgHsAzP2HmNwRF2BKC2kJcQRQ7G4z0am5Xqq0m6MajVFhV6 itlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fuiIySm4c6+eg7s6v2OeYyG0eBFO5EIu7Ww/Zdpp2HM=; b=AxdAvXHg7mjUFk//iyNigffhG8/oqRsHjbw8nuGiQSNtBZsXWMjT+i2izFRyloCNf/ uyFW8sRqRkAKNuHHIrKWUSFOuHw0rPI2gQCvt1ikyuidLrr7+7/fqIztZ9uaD6sI6Eao 3pz9Utdc6fK2BBO4r2pFELQgU6AU0zxzcbjysu6Bu0ZH0y736cJCGJF4s5ppKyI1tvkj JBeUm4MeII0pPcSbwCnfi5gRfvtUhhR5wmAIo5DXcUkEMfxaPWR+SPMZ82QuyJquhDa9 t+IvwsoqWIWy9gfSX1pFFHvpIqmBPCOO7uNA8PHeURel2W0VZuBzXwYoSwXCQH6wdhf9 FRBg== X-Gm-Message-State: AFqh2krGyqk9HNZQpZVxlSJuKCp3q/imNLrCJqye9/KrDnA9sM2P+Fzu AlGcTTYlu1EMI9WPUbPgyhM= X-Google-Smtp-Source: AMrXdXvEfIZFZwaZoKhERtNbwnvI5clSfBPMcUKX4t0deIpWulVeSr9o/xVmcuzRO5i/0IwTJG7R6Q== X-Received: by 2002:a05:6214:5908:b0:531:94d7:a433 with SMTP id lp8-20020a056214590800b0053194d7a433mr47336049qvb.26.1672854568551; Wed, 04 Jan 2023 09:49:28 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id u5-20020a05620a0c4500b006cfc1d827cbsm24104369qki.9.2023.01.04.09.49.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 09:49:28 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 12:49:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 03/19] clk: at91: sam9x60: Register the required clocks for USB Content-Language: en-US To: Sergiu Moga , eugen.hristev@microchip.com, durai.manickamkr@microchip.com, sandeep.sheriker@microchip.com, greg@embeddedgreg.com, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com, lukma@denx.de, marex@denx.de, michael@walle.cc, hs@denx.de, claudiu.beznea@microchip.com, balamanikandan.gunasundar@microchip.com, michael@amarulasolutions.com, dario.binacchi@amarulasolutions.com, cristian.birsan@microchip.com, peng.fan@nxp.com, mihai.sain@microchip.com, weijie.gao@mediatek.com, sumit.garg@linaro.org, jim.t90615@gmail.com, michal.simek@amd.com, sjg@chromium.org, j-keerthy@ti.com, ashok.reddy.soma@xilinx.com Cc: u-boot@lists.denx.de References: <20221222105357.105457-1-sergiu.moga@microchip.com> <20221222105357.105457-4-sergiu.moga@microchip.com> From: Sean Anderson In-Reply-To: <20221222105357.105457-4-sergiu.moga@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 12/22/22 05:53, Sergiu Moga wrote: > Register into DM the clocks required to properly enable USB functionality > within the bootloader. > > Signed-off-by: Sergiu Moga > --- > > > v1 -> v2: > - No change > > > v2 -> v3: > - Remove the no longer required #if CONFIG_IS_ENABLED(AT91_SAM9X60_USB) > > > v3 -> v5: > - No change > > > > drivers/clk/at91/sam9x60.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c > index 6b5486c6c9..14c2ffcac1 100644 > --- a/drivers/clk/at91/sam9x60.c > +++ b/drivers/clk/at91/sam9x60.c > @@ -76,6 +76,8 @@ enum pmc_clk_ids { > ID_QSPI = 18, > > ID_MCK_PRES = 19, > + ID_USBCK = 20, > + ID_UHPCK = 21, > > ID_MAX, > }; > @@ -99,6 +101,7 @@ static const char *clk_names[] = { > [ID_PLL_A_DIV] = "plla_divpmcck", > [ID_MCK_PRES] = "mck_pres", > [ID_MCK_DIV] = "mck_div", > + [ID_USBCK] = "usbck", > }; > > /* Fractional PLL output range. */ > @@ -171,6 +174,13 @@ static const struct clk_pcr_layout pcr_layout = { > .pid_mask = GENMASK(6, 0), > }; > > +/* USB clock layout */ > +static const struct clk_usbck_layout usbck_layout = { > + .offset = 0x38, > + .usbs_mask = GENMASK(1, 0), > + .usbdiv_mask = GENMASK(11, 8), > +}; > + > /** > * PLL clocks description > * @n: clock name > @@ -266,6 +276,7 @@ static const struct { > u8 cid; > } sam9x60_systemck[] = { > { .n = "ddrck", .p = "mck_div", .id = 2, .cid = ID_DDR, }, > + { .n = "uhpck", .p = "usbck", .id = 6, .cid = ID_UHPCK }, > { .n = "pck0", .p = "prog0", .id = 8, .cid = ID_PCK0, }, > { .n = "pck1", .p = "prog1", .id = 9, .cid = ID_PCK1, }, > { .n = "qspick", .p = "mck_div", .id = 19, .cid = ID_QSPI, }, > @@ -543,6 +554,28 @@ static int sam9x60_clk_probe(struct udevice *dev) > } > clk_dm(AT91_TO_CLK_ID(PMC_TYPE_CORE, ID_MCK_DIV), c); > > + /* Register usbck. */ > + p[0] = clk_names[ID_PLL_A_DIV]; > + p[1] = clk_names[ID_PLL_U_DIV]; > + p[2] = clk_names[ID_MAIN_XTAL]; > + m[0] = 0; > + m[1] = 1; > + m[2] = 2; > + cm[0] = AT91_TO_CLK_ID(PMC_TYPE_CORE, ID_PLL_A_DIV); > + cm[1] = AT91_TO_CLK_ID(PMC_TYPE_CORE, ID_PLL_U_DIV); > + cm[2] = AT91_TO_CLK_ID(PMC_TYPE_CORE, ID_MAIN_XTAL); > + prepare_mux_table(clkmuxallocs, clkmuxallocindex, tmpclkmux, cm, > + 3, fail); > + prepare_mux_table(muxallocs, muxallocindex, tmpmux, m, 3, fail); > + c = sam9x60_clk_register_usb(base, clk_names[ID_USBCK], p, 3, > + &usbck_layout, tmpclkmux, tmpmux, > + ID_USBCK); > + if (IS_ERR(c)) { > + ret = PTR_ERR(c); > + goto fail; > + } > + clk_dm(AT91_TO_CLK_ID(PMC_TYPE_CORE, ID_USBCK), c); > + > /* Register programmable clocks. */ > p[0] = clk_names[ID_MD_SLCK]; > p[1] = clk_names[ID_TD_SLCK]; Acked-by: Sean Anderson