From: "ordex (Code Review)" Date: Thu, 30 Jan 2025 08:44:52 +0000 In-Reply-To: References: Reply-To: a@...2181..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Skih6nfq0fo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: flichtenheld , plaisthos , openvpn-devel --Skih6nfq0fo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/814?usp=3Demail ) Change subject: mudp.c: keep offset value when resetting buffer ...................................................................... Patch Set 12: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/814/comment/ef68c003_57b839a6 : PS12, Line 58: ASSERT(buf_init(&c->c2.buffers->aux_buf, buf.offset)); under what circumstance do we expect this ASSERT to be triggered? I am always scared to introduce new ASSERTs because a temporary condition m= ay lead the server to "assert-out" and this may not be nice. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72 Gerrit-Change-Number: 814 Gerrit-PatchSet: 12 Gerrit-Owner: stipa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: stipa Gerrit-Comment-Date: Thu, 30 Jan 2025 08:44:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --Skih6nfq0fo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos, stipa.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/mudp.c:

    • Patch Set #12, Line 58: ASSERT(buf_init(&c-&g= t;c2.buffers->aux_buf, buf.offset));

      under what circumstance do we expect this= ASSERT to be triggered?
      I am always scared to introduce new ASSERTs bec= ause a temporary condition may lead the server to "assert-out" an= d this may not be nice.

To view, visit change 814. To = unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I145573555aaace5e94774b5f977= d032d3747ed72
Gerrit-Change-Number: 814
Gerrit-PatchSet: 12
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Thu, 30 Jan 2025 08:44:52= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--Skih6nfq0fo=--