From: Michal Simek Date: Tue, 9 Apr 2019 09:03:05 +0200 Subject: [U-Boot] [PATCH v2 2/3] i2c: muxes: pca954x: clarify enable field In-Reply-To: <20190409065743.32174-2-luca@lucaceresoli.net> References: <20190409065743.32174-1-luca@lucaceresoli.net> <20190409065743.32174-2-luca@lucaceresoli.net> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09. 04. 19 8:57, Luca Ceresoli wrote: > The chip_desc.enable field is used only for muxes, not for switches. > Document it and remove the unused values. > > Signed-off-by: Luca Ceresoli > Reviewed-by: Heiko Schocher > > --- > > Changes v1 -> v2: > - fix typo in commit message (Michal) > --- > drivers/i2c/muxes/pca954x.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c > index bd4e9abe5f3c..5669753ce14d 100644 > --- a/drivers/i2c/muxes/pca954x.c > +++ b/drivers/i2c/muxes/pca954x.c > @@ -22,7 +22,7 @@ enum pca_type { > }; > > struct chip_desc { > - u8 enable; > + u8 enable; /* Enable mask in ctl register (used for muxes only) */ > enum muxtype { > pca954x_ismux = 0, > pca954x_isswi, > @@ -48,12 +48,10 @@ static const struct chip_desc chips[] = { > .width = 8, > }, > [PCA9548] = { > - .enable = 0x8, > .muxtype = pca954x_isswi, > .width = 8, > }, > [PCA9646] = { > - .enable = 0x0, > .muxtype = pca954x_isswi, > .width = 4, > }, > Acked-by: Michal Simek Thanks, Michal