Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28E6C43381 for ; Mon, 4 Mar 2019 18:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADF6E20823 for ; Mon, 4 Mar 2019 18:50:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H+YjkgnF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbfCDSuu (ORCPT ); Mon, 4 Mar 2019 13:50:50 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50530 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbfCDSuu (ORCPT ); Mon, 4 Mar 2019 13:50:50 -0500 Received: by mail-wm1-f68.google.com with SMTP id x7so226495wmj.0 for ; Mon, 04 Mar 2019 10:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=SznUC+z29f/V/A+J/fYvBkqjwMU2IywCVgKuYli7VcE=; b=H+YjkgnFE60WvhYP4THmQ9uNqW9wsOwsuqS+Qr/7WMIoE+ECAbFgFS8KLNstf2ACMD nUQ1/JV8/EW9QlojcRM65Xl88AXGx4tUL/XM0HXtjH+W8S3gRU2Vt9p9OyJNjsRku1uh KYWNQOsCgEu/pecCCIjcANgcJKKxkwwBJatQnxLy1TKK4lfWJQBcpyxcAHUWM4GXNdGH zIRJU4W01ompgvjJCR5GEeMTVayU1h4NLKdLgpa3SeYzWcBZCzShNHnXrm48vhUqfWAM +lK3BQLYbENfGHNIObZHYMsvbpeEzu+ICnzY6iiWusfEgE82OiB6rKrhoz+ZIS1rlW/3 cqNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=SznUC+z29f/V/A+J/fYvBkqjwMU2IywCVgKuYli7VcE=; b=kHBpR7pH8qb4SOp/6JJ6ACe7uBw7iI0YIVxzgH65xbRe4wiLoNL0cLriDRPQ2YLXKT GyVNqCLjaM5zfbcs/2/1mC1tdzGv9msWZXMZiHZZ4Ho6092mnyN0I+8H3/oHunY33/q0 zSOZOes323Apy4pC5ujec/RIz49plye6ZumLmdEdnJx0sW403zX4X0gp0gdRxH5CPR0j 9Zlfpo4ohuXZtL4dsMq2ucI7NApoPdlMkUvErR8UAsTbkP5eLwlvbLXLNCXP2dM0jfDn YJAV505r2KKUqJF9Z59/0hFasUr+y9a61gNxaSg2R0D0DHcLOY+0TzgKEQ8GwZZJuXIv P0qg== X-Gm-Message-State: APjAAAWtIw5E+xPHRdAoufgm/1XExtJQ58igMR1yAuK4UAfb8F8gBhpN qX3uOyVhoqKg0owFW3YrsJzfXSr+ X-Google-Smtp-Source: APXvYqypLzZn6+3fow1hK3pd9ggG+N3Z1+dHh5X/wiwO5S3zCUk7m11zss+hSpx+OBT8VVoyIr1CtQ== X-Received: by 2002:a1c:d049:: with SMTP id h70mr321933wmg.81.1551725448141; Mon, 04 Mar 2019 10:50:48 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:d8e4:889a:5ed6:37cb? (p200300EA8BF1E200D8E4889A5ED637CB.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:d8e4:889a:5ed6:37cb]) by smtp.googlemail.com with ESMTPSA id d16sm6750092wrx.29.2019.03.04.10.50.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Mar 2019 10:50:47 -0800 (PST) To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net-next] net: phy: use phy_modify_mmd_changed in genphy_c45_an_config_aneg Message-ID: Date: Mon, 4 Mar 2019 19:50:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org As can be seen from the usage of the return value, we should use phy_modify_mmd_changed() here. Fixes: 9a5dc8af4416 ("net: phy: add genphy_c45_an_config_aneg") Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index c596eb54e..9e24d9569 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -99,10 +99,10 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev) adv = linkmode_adv_to_mii_adv_t(phydev->advertising); - ret = phy_modify_mmd(phydev, MDIO_MMD_AN, MDIO_AN_ADVERTISE, - ADVERTISE_ALL | ADVERTISE_100BASE4 | - ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM, - adv); + ret = phy_modify_mmd_changed(phydev, MDIO_MMD_AN, MDIO_AN_ADVERTISE, + ADVERTISE_ALL | ADVERTISE_100BASE4 | + ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM, + adv); if (ret < 0) return ret; if (ret > 0) @@ -110,11 +110,10 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev) adv = linkmode_adv_to_mii_10gbt_adv_t(phydev->advertising); - ret = phy_modify_mmd(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_CTRL, - MDIO_AN_10GBT_CTRL_ADV10G | - MDIO_AN_10GBT_CTRL_ADV5G | - MDIO_AN_10GBT_CTRL_ADV2_5G, - adv); + ret = phy_modify_mmd_changed(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_CTRL, + MDIO_AN_10GBT_CTRL_ADV10G | + MDIO_AN_10GBT_CTRL_ADV5G | + MDIO_AN_10GBT_CTRL_ADV2_5G, adv); if (ret < 0) return ret; if (ret > 0) -- 2.21.0