From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/3] drm/amdgpu: Make pin_size values atomic Date: Thu, 12 Jul 2018 09:39:17 +0200 Message-ID: References: <20180711162342.14835-1-michel@daenzer.net> <20180711162342.14835-3-michel@daenzer.net> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180711162342.14835-3-michel-otUistvHUpPR7s880joybQ@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Michel_D=c3=a4nzer?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTEuMDcuMjAxOCB1bSAxODoyMyBzY2hyaWViIE1pY2hlbCBEw6RuemVyOgo+IEZyb206IE1p Y2hlbCBEw6RuemVyIDxtaWNoZWwuZGFlbnplckBhbWQuY29tPgo+Cj4gQ29uY3VycmVudCBleGVj dXRpb24gb2YgdGhlIG5vbi1hdG9taWMgYXJpdGhtZXRpYyBjb3VsZCByZXN1bHQgaW4KPiBjb21w bGV0ZWx5IGJvZ3VzIHZhbHVlcy4KPgo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gQnVn emlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvMTA2ODcyCj4gU2lnbmVkLW9mZi1i eTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVyQGFtZC5jb20+CgpSZXZpZXdlZC1ieTog Q2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgoKPiAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oICAgICAgICB8ICA2ICsrKy0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMgICAgIHwgIDIgKy0KPiAgIGRy aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYyAgICB8IDIyICsrKysrKysrKysr LS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3Qu YyB8IDE4ICsrKysrKysrKystLS0tLS0tLQo+ICAgNCBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRp b25zKCspLCAyMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHUuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5o Cj4gaW5kZXggNzdhYjA2YmYyNmQ1Li5mMDBiZTNkODBhYTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHUuaAo+IEBAIC0xNTkyLDkgKzE1OTIsOSBAQCBzdHJ1Y3QgYW1kZ3B1X2Rl dmljZSB7Cj4gICAJREVDTEFSRV9IQVNIVEFCTEUobW5faGFzaCwgNyk7Cj4gICAKPiAgIAkvKiB0 cmFja2luZyBwaW5uZWQgbWVtb3J5ICovCj4gLQl1NjQgdnJhbV9waW5fc2l6ZTsKPiAtCXU2NCB2 aXNpYmxlX3Bpbl9zaXplOwo+IC0JdTY0IGdhcnRfcGluX3NpemU7Cj4gKwlhdG9taWM2NF90IHZy YW1fcGluX3NpemU7Cj4gKwlhdG9taWM2NF90IHZpc2libGVfcGluX3NpemU7Cj4gKwlhdG9taWM2 NF90IGdhcnRfcGluX3NpemU7Cj4gICAKPiAgIAkvKiBhbWRrZmQgaW50ZXJmYWNlICovCj4gICAJ c3RydWN0IGtmZF9kZXYgICAgICAgICAgKmtmZDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfY3MuYwo+IGluZGV4IDk4ODFhMWU1NWRmMy4uNWEyYTViYTI5ZjlhIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPiBAQCAtMjYyLDcgKzI2Miw3IEBAIHN0 YXRpYyB2b2lkIGFtZGdwdV9jc19nZXRfdGhyZXNob2xkX2Zvcl9tb3ZlcyhzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldiwKPiAgIAkJcmV0dXJuOwo+ICAgCX0KPiAgIAo+IC0JdG90YWxfdnJhbSA9 IGFkZXYtPmdtYy5yZWFsX3ZyYW1fc2l6ZSAtIGFkZXYtPnZyYW1fcGluX3NpemU7Cj4gKwl0b3Rh bF92cmFtID0gYWRldi0+Z21jLnJlYWxfdnJhbV9zaXplIC0gYXRvbWljNjRfcmVhZCgmYWRldi0+ dnJhbV9waW5fc2l6ZSk7Cj4gICAJdXNlZF92cmFtID0gYW1kZ3B1X3ZyYW1fbWdyX3VzYWdlKCZh ZGV2LT5tbWFuLmJkZXYubWFuW1RUTV9QTF9WUkFNXSk7Cj4gICAJZnJlZV92cmFtID0gdXNlZF92 cmFtID49IHRvdGFsX3ZyYW0gPyAwIDogdG90YWxfdnJhbSAtIHVzZWRfdnJhbTsKPiAgIAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMgYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMKPiBpbmRleCBiMWVhNDNlZThiODcu LjI1OGI2ZjczY2JkZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfa21zLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21z LmMKPiBAQCAtNTAxLDEzICs1MDEsMTMgQEAgc3RhdGljIGludCBhbWRncHVfaW5mb19pb2N0bChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUKPiAgIAlj YXNlIEFNREdQVV9JTkZPX1ZSQU1fR1RUOiB7Cj4gICAJCXN0cnVjdCBkcm1fYW1kZ3B1X2luZm9f dnJhbV9ndHQgdnJhbV9ndHQ7Cj4gICAKPiAtCQl2cmFtX2d0dC52cmFtX3NpemUgPSBhZGV2LT5n bWMucmVhbF92cmFtX3NpemU7Cj4gLQkJdnJhbV9ndHQudnJhbV9zaXplIC09IGFkZXYtPnZyYW1f cGluX3NpemU7Cj4gLQkJdnJhbV9ndHQudnJhbV9jcHVfYWNjZXNzaWJsZV9zaXplID0gYWRldi0+ Z21jLnZpc2libGVfdnJhbV9zaXplOwo+IC0JCXZyYW1fZ3R0LnZyYW1fY3B1X2FjY2Vzc2libGVf c2l6ZSAtPSBhZGV2LT52aXNpYmxlX3Bpbl9zaXplOwo+ICsJCXZyYW1fZ3R0LnZyYW1fc2l6ZSA9 IGFkZXYtPmdtYy5yZWFsX3ZyYW1fc2l6ZSAtCj4gKwkJCWF0b21pYzY0X3JlYWQoJmFkZXYtPnZy YW1fcGluX3NpemUpOwo+ICsJCXZyYW1fZ3R0LnZyYW1fY3B1X2FjY2Vzc2libGVfc2l6ZSA9IGFk ZXYtPmdtYy52aXNpYmxlX3ZyYW1fc2l6ZSAtCj4gKwkJCWF0b21pYzY0X3JlYWQoJmFkZXYtPnZp c2libGVfcGluX3NpemUpOwo+ICAgCQl2cmFtX2d0dC5ndHRfc2l6ZSA9IGFkZXYtPm1tYW4uYmRl di5tYW5bVFRNX1BMX1RUXS5zaXplOwo+ICAgCQl2cmFtX2d0dC5ndHRfc2l6ZSAqPSBQQUdFX1NJ WkU7Cj4gLQkJdnJhbV9ndHQuZ3R0X3NpemUgLT0gYWRldi0+Z2FydF9waW5fc2l6ZTsKPiArCQl2 cmFtX2d0dC5ndHRfc2l6ZSAtPSBhdG9taWM2NF9yZWFkKCZhZGV2LT5nYXJ0X3Bpbl9zaXplKTsK PiAgIAkJcmV0dXJuIGNvcHlfdG9fdXNlcihvdXQsICZ2cmFtX2d0dCwKPiAgIAkJCQkgICAgbWlu KChzaXplX3Qpc2l6ZSwgc2l6ZW9mKHZyYW1fZ3R0KSkpID8gLUVGQVVMVCA6IDA7Cj4gICAJfQo+ IEBAIC01MTYsMTYgKzUxNiwxNiBAQCBzdGF0aWMgaW50IGFtZGdwdV9pbmZvX2lvY3RsKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZQo+ICAgCj4gICAJ CW1lbXNldCgmbWVtLCAwLCBzaXplb2YobWVtKSk7Cj4gICAJCW1lbS52cmFtLnRvdGFsX2hlYXBf c2l6ZSA9IGFkZXYtPmdtYy5yZWFsX3ZyYW1fc2l6ZTsKPiAtCQltZW0udnJhbS51c2FibGVfaGVh cF9zaXplID0KPiAtCQkJYWRldi0+Z21jLnJlYWxfdnJhbV9zaXplIC0gYWRldi0+dnJhbV9waW5f c2l6ZTsKPiArCQltZW0udnJhbS51c2FibGVfaGVhcF9zaXplID0gYWRldi0+Z21jLnJlYWxfdnJh bV9zaXplIC0KPiArCQkJYXRvbWljNjRfcmVhZCgmYWRldi0+dnJhbV9waW5fc2l6ZSk7Cj4gICAJ CW1lbS52cmFtLmhlYXBfdXNhZ2UgPQo+ICAgCQkJYW1kZ3B1X3ZyYW1fbWdyX3VzYWdlKCZhZGV2 LT5tbWFuLmJkZXYubWFuW1RUTV9QTF9WUkFNXSk7Cj4gICAJCW1lbS52cmFtLm1heF9hbGxvY2F0 aW9uID0gbWVtLnZyYW0udXNhYmxlX2hlYXBfc2l6ZSAqIDMgLyA0Owo+ICAgCj4gICAJCW1lbS5j cHVfYWNjZXNzaWJsZV92cmFtLnRvdGFsX2hlYXBfc2l6ZSA9Cj4gICAJCQlhZGV2LT5nbWMudmlz aWJsZV92cmFtX3NpemU7Cj4gLQkJbWVtLmNwdV9hY2Nlc3NpYmxlX3ZyYW0udXNhYmxlX2hlYXBf c2l6ZSA9Cj4gLQkJCWFkZXYtPmdtYy52aXNpYmxlX3ZyYW1fc2l6ZSAtIGFkZXYtPnZpc2libGVf cGluX3NpemU7Cj4gKwkJbWVtLmNwdV9hY2Nlc3NpYmxlX3ZyYW0udXNhYmxlX2hlYXBfc2l6ZSA9 IGFkZXYtPmdtYy52aXNpYmxlX3ZyYW1fc2l6ZSAtCj4gKwkJCWF0b21pYzY0X3JlYWQoJmFkZXYt PnZpc2libGVfcGluX3NpemUpOwo+ICAgCQltZW0uY3B1X2FjY2Vzc2libGVfdnJhbS5oZWFwX3Vz YWdlID0KPiAgIAkJCWFtZGdwdV92cmFtX21ncl92aXNfdXNhZ2UoJmFkZXYtPm1tYW4uYmRldi5t YW5bVFRNX1BMX1ZSQU1dKTsKPiAgIAkJbWVtLmNwdV9hY2Nlc3NpYmxlX3ZyYW0ubWF4X2FsbG9j YXRpb24gPQo+IEBAIC01MzMsOCArNTMzLDggQEAgc3RhdGljIGludCBhbWRncHVfaW5mb19pb2N0 bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUKPiAg IAo+ICAgCQltZW0uZ3R0LnRvdGFsX2hlYXBfc2l6ZSA9IGFkZXYtPm1tYW4uYmRldi5tYW5bVFRN X1BMX1RUXS5zaXplOwo+ICAgCQltZW0uZ3R0LnRvdGFsX2hlYXBfc2l6ZSAqPSBQQUdFX1NJWkU7 Cj4gLQkJbWVtLmd0dC51c2FibGVfaGVhcF9zaXplID0gbWVtLmd0dC50b3RhbF9oZWFwX3NpemUK PiAtCQkJLSBhZGV2LT5nYXJ0X3Bpbl9zaXplOwo+ICsJCW1lbS5ndHQudXNhYmxlX2hlYXBfc2l6 ZSA9IG1lbS5ndHQudG90YWxfaGVhcF9zaXplIC0KPiArCQkJYXRvbWljNjRfcmVhZCgmYWRldi0+ Z2FydF9waW5fc2l6ZSk7Cj4gICAJCW1lbS5ndHQuaGVhcF91c2FnZSA9Cj4gICAJCQlhbWRncHVf Z3R0X21ncl91c2FnZSgmYWRldi0+bW1hbi5iZGV2Lm1hbltUVE1fUExfVFRdKTsKPiAgIAkJbWVt Lmd0dC5tYXhfYWxsb2NhdGlvbiA9IG1lbS5ndHQudXNhYmxlX2hlYXBfc2l6ZSAqIDMgLyA0Owo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmMg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmMKPiBpbmRleCA3NTI0 ODQzMjg2NjUuLjI0ZDZmYjg3ZjNiNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfb2JqZWN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfb2JqZWN0LmMKPiBAQCAtOTE2LDExICs5MTYsMTIgQEAgaW50IGFtZGdwdV9ib19w aW5fcmVzdHJpY3RlZChzdHJ1Y3QgYW1kZ3B1X2JvICpibywgdTMyIGRvbWFpbiwKPiAgIAo+ICAg CWRvbWFpbiA9IGFtZGdwdV9tZW1fdHlwZV90b19kb21haW4oYm8tPnRiby5tZW0ubWVtX3R5cGUp Owo+ICAgCWlmIChkb21haW4gPT0gQU1ER1BVX0dFTV9ET01BSU5fVlJBTSkgewo+IC0JCWFkZXYt PnZyYW1fcGluX3NpemUgKz0gYW1kZ3B1X2JvX3NpemUoYm8pOwo+IC0JCWFkZXYtPnZpc2libGVf cGluX3NpemUgKz0KPiAtCQkJYW1kZ3B1X2JvX3NpemUoYm8pIC0gYW1kZ3B1X3ZyYW1fbWdyX2Jv X2ludmlzaWJsZV9zaXplKGJvKTsKPiArCQlhdG9taWM2NF9hZGQoYW1kZ3B1X2JvX3NpemUoYm8p LCAmYWRldi0+dnJhbV9waW5fc2l6ZSk7Cj4gKwkJYXRvbWljNjRfYWRkKGFtZGdwdV9ib19zaXpl KGJvKSAtCj4gKwkJCSAgICAgYW1kZ3B1X3ZyYW1fbWdyX2JvX2ludmlzaWJsZV9zaXplKGJvKSwK PiArCQkJICAgICAmYWRldi0+dmlzaWJsZV9waW5fc2l6ZSk7Cj4gICAJfSBlbHNlIGlmIChkb21h aW4gPT0gQU1ER1BVX0dFTV9ET01BSU5fR1RUKSB7Cj4gLQkJYWRldi0+Z2FydF9waW5fc2l6ZSAr PSBhbWRncHVfYm9fc2l6ZShibyk7Cj4gKwkJYXRvbWljNjRfYWRkKGFtZGdwdV9ib19zaXplKGJv KSwgJmFkZXYtPmdhcnRfcGluX3NpemUpOwo+ICAgCX0KPiAgIAo+ICAgZXJyb3I6Cj4gQEAgLTk2 OSwxMSArOTcwLDEyIEBAIGludCBhbWRncHVfYm9fdW5waW4oc3RydWN0IGFtZGdwdV9ibyAqYm8p Cj4gICAJCXJldHVybiAwOwo+ICAgCj4gICAJaWYgKGJvLT50Ym8ubWVtLm1lbV90eXBlID09IFRU TV9QTF9WUkFNKSB7Cj4gLQkJYWRldi0+dnJhbV9waW5fc2l6ZSAtPSBhbWRncHVfYm9fc2l6ZShi byk7Cj4gLQkJYWRldi0+dmlzaWJsZV9waW5fc2l6ZSAtPQo+IC0JCQlhbWRncHVfYm9fc2l6ZShi bykgLSBhbWRncHVfdnJhbV9tZ3JfYm9faW52aXNpYmxlX3NpemUoYm8pOwo+ICsJCWF0b21pYzY0 X3N1YihhbWRncHVfYm9fc2l6ZShibyksICZhZGV2LT52cmFtX3Bpbl9zaXplKTsKPiArCQlhdG9t aWM2NF9zdWIoYW1kZ3B1X2JvX3NpemUoYm8pIC0KPiArCQkJICAgICBhbWRncHVfdnJhbV9tZ3Jf Ym9faW52aXNpYmxlX3NpemUoYm8pLAo+ICsJCQkgICAgICZhZGV2LT52aXNpYmxlX3Bpbl9zaXpl KTsKPiAgIAl9IGVsc2UgaWYgKGJvLT50Ym8ubWVtLm1lbV90eXBlID09IFRUTV9QTF9UVCkgewo+ IC0JCWFkZXYtPmdhcnRfcGluX3NpemUgLT0gYW1kZ3B1X2JvX3NpemUoYm8pOwo+ICsJCWF0b21p YzY0X3N1YihhbWRncHVfYm9fc2l6ZShibyksICZhZGV2LT5nYXJ0X3Bpbl9zaXplKTsKPiAgIAl9 Cj4gICAKPiAgIAlmb3IgKGkgPSAwOyBpIDwgYm8tPnBsYWNlbWVudC5udW1fcGxhY2VtZW50OyBp KyspIHsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFt ZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=