From: "ordex (Code Review)"
Date: Wed, 16 Apr 2025 11:52:42 +0000
In-Reply-To:
References:
Reply-To: antonio@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="pPCsCltRbVk="; charset=UTF-8
Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole
project with clang-format
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: flichtenheld
Cc: plaisthos , openvpn-devel
--pPCsCltRbVk=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/791?usp=3Demail )
Change subject: Reformat the whole project with clang-format
......................................................................
Patch Set 14:
(2 comments)
File sample/sample-plugins/client-connect/sample-client-connect.c:
http://gerrit.openvpn.net/c/openvpn/+/791/comment/cd08c6bb_0b6173ee :
PS14, Line 252: "env has UV_WANT_CC_ASYNC=3D%d, but "
> Has nothing to do with this patch though, AFAICT
You're right. I thought it was the right moment to trigger the discussion, =
so we can possibly find a clang-format option that addresses this.
File sample/sample-plugins/defer/multi-auth.c:
http://gerrit.openvpn.net/c/openvpn/+/791/comment/6b1aef69_72e254a0 :
PS14, Line 294: const char *envp[])
> yes. This is BinPackParameters. [=E2=80=A6]
I think we should. It will also make BinPackParameters consistent with BinP=
ackArguments
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 14
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 16 Apr 2025 11:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--pPCsCltRbVk=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.