From: "flichtenheld (Code Review)" Date: Wed, 8 May 2024 14:21:10 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="+MH+oN46iXA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , plaisthos , openvpn-devel --+MH+oN46iXA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/556?usp=3Demail ) Change subject: configure: Try to detect LZO with pkg-config ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > Does not work for me yet. [=E2=80=A6] Yeah, I tried to include the -llzo check in pkg-config, which just made no = sense. And it did not work for the case where LZO_CFLAGS were important any= way. I now decided to just remove it completely. File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/556/comment/1166fc22_a203022f : PS2, Line 1148: if test -z "${LZO_CFLAGS}" -a -z "${LZO_LIBS}"; then > Isn't this -z LZO_LIBS always true since it is under the -z LZO_LIBS chec= k anyway? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee61fee74f26e693 Gerrit-Change-Number: 556 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Wed, 08 May 2024 14:21:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --+MH+oN46iXA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, plaisthos.

View C= hange

2 comments:

    =
  • Patchset:

    To view, visit change 556. To unsubsc= ribe, or for help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee6= 1fee74f26e693
    Gerrit-Change-Number: 556
    Gerrit-PatchSet: 3
    Gerrit-Owner: flichtenheld <frank@...2723...= .>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: cron2 <gert@...1296...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: cron2 <gert@...1296...>= ;
    Gerrit-Comment-Date: Wed, 08 May 2024 14:21:10= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
    Comment-In-Reply-To: cron2 <gert@...1296...= >
    Gerrit-MessageType: comment
    --+MH+oN46iXA=--