Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE96FC4338F for ; Thu, 19 Aug 2021 18:55:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 906DB60E93 for ; Thu, 19 Aug 2021 18:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 906DB60E93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.169107.308906 (Exim 4.92) (envelope-from ) id 1mGnCi-0006RE-2Y; Thu, 19 Aug 2021 18:55:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 169107.308906; Thu, 19 Aug 2021 18:55:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGnCh-0006R7-VP; Thu, 19 Aug 2021 18:55:51 +0000 Received: by outflank-mailman (input) for mailman id 169107; Thu, 19 Aug 2021 18:55:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGnCh-0006Qx-44 for xen-devel@lists.xenproject.org; Thu, 19 Aug 2021 18:55:51 +0000 Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f3ccfc8-3ba9-4f71-b888-27b8c6368d79; Thu, 19 Aug 2021 18:55:50 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id k8so10556980wrn.3 for ; Thu, 19 Aug 2021 11:55:50 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec? ([2a00:23c5:5785:9a01:ad9a:ab78:5748:a7ec]) by smtp.gmail.com with ESMTPSA id f17sm3090812wmq.17.2021.08.19.11.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Aug 2021 11:55:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f3ccfc8-3ba9-4f71-b888-27b8c6368d79 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=beKr+18OVxhdpZsKonr41wMvnFcE0jP4JQYsuR2VgVM=; b=VE7vAMAcKNDdrlVka/CeMl3qBXfWD+oQcQ4o23QkI9tcNuSBHR9zdZOeAO0njsO8cM SqyMxoVLZ+eo8Nbg+9+eTZF/qkYwts+ZNtI7OkUCrONlHjk5XOglWCYwMr//0djUAiWm kxrv7CQO4/AFpE/nwrWCpsb5HBU376sagSxeCBxPoxa0+PvtEcQ/78XcW3zENBzU1aYI fOcTnxvuWgdyNYLNG2vk2r6NOwW/CU3dcdnVY0BTUd9EgXIl1jXnMAA7lJDUz7Rqp5Qm 439nN5C2k2ZsoziD99iz8cVLOht222+6wHJPGOjW+Kk4OVxZtm0I+gUBpKCc6wE9PQ7H iuvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=beKr+18OVxhdpZsKonr41wMvnFcE0jP4JQYsuR2VgVM=; b=lWfCLTbDMjTMRfuFrILUtFyBzStHzOK+uUbLBk0Y7Kz2b0COWhsChtBHsPnPusjvr8 RmAzX1+4TCJC2s+0VY00LHdrQty9W9uIDSzuAkJ/4FaifpG/AuNozDLRx/4CFL7KMMxw FdQTxo/iJMRf9D7Cy7BQ2BC73ZI/PK2k93JvP3DCUK5umwUwy+nFPKDYfosgahTnxkPL HeTwYi2qnkIkYoYnki/tDhDtZM6/TXAcJ2qY1NppaViG7PhIlVfxKQ5ETtr1qmo5Kmjv DQbSbGGpCdrENcMYqWfOP6Odjg0jWDwiSYYBPNYOF0qcDn9mWchaOJjBka0TrjoeSOT0 7jyw== X-Gm-Message-State: AOAM533tSvVlJeMgAZGRHC3OWim35UhK1nAe3MHECBxExpZgjLyyVWhK dC0aGEJ2qFSqIindG8xme+A= X-Google-Smtp-Source: ABdhPJy1824HRqYGlTjrIIe7nHo674eESKBo/yy1LwOHSy5Zu5JhUIdCnGIaX66c9Dcp5Ao0MKtT6A== X-Received: by 2002:a5d:6352:: with SMTP id b18mr5506947wrw.116.1629399349665; Thu, 19 Aug 2021 11:55:49 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH] AMD/IOMMU: don't leave page table mapped when unmapping ... To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper References: Message-ID: Date: Thu, 19 Aug 2021 19:55:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 19/08/2021 09:03, Jan Beulich wrote: > ... an already not mapped page. With all other exit paths doing the > unmap, I have no idea how I managed to miss that aspect at the time. > > Fixes: ad591454f069 ("AMD/IOMMU: don't needlessly trigger errors/crashes when unmapping a page") > Signed-off-by: Jan Beulich > Reviewed-by: Paul Durrant