Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9827B10F995A for ; Wed, 8 Apr 2026 16:10:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 313A410E69F; Wed, 8 Apr 2026 16:10:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="f33m7SyS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF5AC10E6A0 for ; Wed, 8 Apr 2026 16:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775664626; x=1807200626; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=2O7AP0QL9ZgiKdI+OYUj4STyfc5ZEzdQs9WIW3NK+Lk=; b=f33m7SySdHJy1AWJ5qCoRDhEfDVCUn4ry7r+tdtlFy/JmOxC195SOdWA /b+NEBIGrwa/CmlQVeTQ++jRa4D5Qjp8FIf4ONx5cpWabAmDcq3MJZKUN HnWCnN2pgI8CvwrhSVC+58Gz4GPdEDF8tJTy58IFMX5iiGg6+N34Lt4Wq bknkuTDQ1J91fJrh6tUO8ekJfE6hDnemWjxobrqw0oz5Eur3rkIuzIm2c WVXpkcWLk47Z6PDi+Wg18NP+VfLl7AL99RjCcJIe6BVrf/e6KzcSZLEJ3 sUetffMj2b3g8D0ACb7ZUfNwT8u3guOBi6sta5DKx5qU+KCCghi2/+6wf A==; X-CSE-ConnectionGUID: ZXuwmaHoTP2tFDnniwK5dw== X-CSE-MsgGUID: AIcfyBkHSNyBt3BWuaiyCQ== X-IronPort-AV: E=McAfee;i="6800,10657,11753"; a="88038081" X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="88038081" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 09:10:25 -0700 X-CSE-ConnectionGUID: N6Md1ic1RuaA9fzXA7Ho8A== X-CSE-MsgGUID: AI3TfUP+SbmsKh3Vvq0a9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="224210384" Received: from krybak-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.32]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 09:10:24 -0700 From: Jani Nikula To: Maarten Lankhorst , Ville =?utf-8?B?U3ly?= =?utf-8?B?asOkbMOk?= Cc: intel-gfx@lists.freedesktop.org Subject: Re: =?utf-8?Q?=E2=9C=97?= i915.CI.Full: failure for drm/i915/display: stop using the configurable fence timeout (rev2) In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20251112155612.8320-1-jani.nikula@intel.com> <176310680567.54560.8073003092226406962@10055242dc62> <3692f126b907c442d76a93957073660d7d9ffd12@intel.com> <44f9b69d23678458f0ab3ff4bec5c45cb05535b8@intel.com> <4d0e3bfe-d3e3-43fb-8964-b9647e914a61@intel.com> Date: Wed, 08 Apr 2026 19:10:20 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 08 Apr 2026, Maarten Lankhorst wrote: > Hey, > > Den 2026-04-08 kl. 17:14, skrev Jani Nikula: >> On Thu, 02 Apr 2026, Maarten Lankhorst wro= te: >>> Den 2026-04-02 kl. 11:40, skrev Jani Nikula: >>>> On Wed, 03 Dec 2025, Maarten Lankhorst w= rote: >>>>> Hey, >>>>> >>>>> Den 2025-11-25 kl. 18:24, skrev Ville Syrj=C3=A4l=C3=A4: >>>>>> On Tue, Nov 25, 2025 at 03:55:02PM +0200, Jani Nikula wrote: >>>>>>> Maarten, Ville, any ideas what to do about these? >>>>>> Looks like we need the timeout to unbreak the modeset vs. reset >>>>>> deadlock in a timely fashion. >>>>>> >>>>>> I'm not where we signal/error the fences the modeset is waiting >>>>>> for, but I guess that must be happening after the whole reset >>>>>> sequence is done. Doing that earlier would seem like another >>>>>> solution, but dunno what other fallout it would have. >>>>> intel_prepare_plane_fb() adds all dma-resv fences for old_obj on >>>>> intel_crtc_needs_modeset(), does it change anything if we remove that, >>>>> at least for the GPU reset commit? >>>> We dropped the ball here a bit, and I'm a bit clueless as to what to >>>> do. Except we'll need to unify i915 and xe here somehow. >>>> >>>> Alternatives: >>>> >>>> - Remove the timeout from i915 (the patch at hand), and fix the fallout >>>> somehow. >>>> >>>> - Add the timeout to xe, and fix the fallout, if any. >>>> >>>> - Add the timeout to display parent interface, which is a bit meh. >>>> >>>> >>> The mention in the commit is old_obj needs to be wait for flip_done, I = do not believe this >>> is the case that it was ever used in hardware supported by xe, so for x= e the wait can be dropped entirely. >>> >>> Is this required for i915 still? In that case you can just eliminate >>> the wait only for xe. >> Trouble is, doing things differently basically means using the parent >> interface no matter what. >> > The specific wait mentioned in intel_plane_prepare_plane_fb is only > used in pre-universal plane overlay support, and in xf86-video-intel > driver on < gen9. (source: > intel_skylake_info specifies gen =3D 0110, > and sna_wait_for_scanline() returns false for gen >=3D 0110 on sna.) > > Adding a < GEN9 check would be sufficient, and not driver specific. The timeout is still configurable on i915. I'm not sure how to resolve that part. BR, Jani. --=20 Jani Nikula, Intel