Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC09BC6FD1C for ; Tue, 21 Mar 2023 03:18:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 47E4785C2E; Tue, 21 Mar 2023 04:18:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 7175285C42; Tue, 21 Mar 2023 04:18:02 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E61C985B0A for ; Tue, 21 Mar 2023 04:17:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id EC8883C01A0; Tue, 21 Mar 2023 11:17:45 +0800 (CST) Message-ID: Date: Tue, 21 Mar 2023 11:17:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc Content-Language: en-US To: Eugen Hristev , jagan@edgeble.ai, u-boot@lists.denx.de, jonas@kwiboo.se References: <20230313125357.26191-1-eugen.hristev@collabora.com> From: Kever Yang In-Reply-To: <20230313125357.26191-1-eugen.hristev@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQh5MTVZOGk4dTBpNGRhOGB5VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSkpLSEpMVUpLS1VLWQ Y+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OFE6CAw4Kz0UFxAqDwhMGD8K ChcKCgpVSlVKTUxCSE1DTU1NTkNMVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJT01INwY+ X-HM-Tid: 0a87022c3c2d2eb0kusnec8883c01a0 X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/3/13 20:53, Eugen Hristev wrote: > To be able to initialize the pinctrl correctly at SPL level and read > u-boot proper from SD-Card, the pinctrl must be initialized. > > Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever > --- > arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > index e1d240baf35d..65aa2095cbf6 100644 > --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > @@ -124,6 +124,8 @@ > }; > > &pinctrl { > + u-boot,dm-spl; > + > usb { > vcc5v0_host_en: vcc5v0-host-en { > rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; > @@ -131,6 +133,22 @@ > }; > }; > > +&sdmmc_bus4 { > + u-boot,dm-spl; > +}; > + > +&sdmmc_clk { > + u-boot,dm-spl; > +}; > + > +&sdmmc_cmd { > + u-boot,dm-spl; > +}; > + > +&sdmmc_det { > + u-boot,dm-spl; > +}; > + > &usb_host0_ehci { > companion = <&usb_host0_ohci>; > phys = <&u2phy2_host>;