Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC04C433E1 for ; Wed, 15 Jul 2020 13:11:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A0F120657 for ; Wed, 15 Jul 2020 13:11:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A0F120657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jvhBW-0000h0-O6; Wed, 15 Jul 2020 13:10:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jvhBV-0000gv-7Y for xen-devel@lists.xenproject.org; Wed, 15 Jul 2020 13:10:53 +0000 X-Inumbo-ID: 9bd0ad15-c69c-11ea-93dd-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9bd0ad15-c69c-11ea-93dd-12813bfff9fa; Wed, 15 Jul 2020 13:10:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CFCB2B61F; Wed, 15 Jul 2020 13:10:54 +0000 (UTC) Subject: Re: [PATCH 00/12] tools: move more libraries into tools/libs To: Jan Beulich , George Dunlap References: <20200715125143.15199-1-jgross@suse.com> <8dbf6f72-8968-47e1-6806-436acdccc928@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Wed, 15 Jul 2020 15:10:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <8dbf6f72-8968-47e1-6806-436acdccc928@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Stewart Hildebrand , Josh Whitehead , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 15.07.20 15:01, Jan Beulich wrote: > On 15.07.2020 14:51, Juergen Gross wrote: >> Move some more libraries under tools/libs, including libxenctrl. This >> is resulting in a lot of cleanup work regarding building libs and >> restructuring of the tools directory. >> >> I have (for now) left out some more libraries like libxenguest and >> libxl, but I can have a try moving those, too, if wanted. >> >> Please note that patch 8 ("tools: move libxenctrl below tools/libs") >> needs the related mini-os and qemu-trad patches applied in order not >> to break the build: >> >> https://lists.xen.org/archives/html/xen-devel/2020-07/msg00548.html >> https://lists.xen.org/archives/html/xen-devel/2020-07/msg00617.html >> >> As discussed at the Xen developers summit this series has been >> selected to act as a test case for sending pull requests via gitlab. >> This is the reason the patches are _not_ sent individually to >> xen-devel, but only the cover letter. > > I don't think I've seen any summary of that discussion, and hence I > also can't judge or know whether this is meant just for huge and > presumably very mechanical series, or as a general form of patch > submission. The immediate point that strikes me is - how would I > comment on such series without having to go to gitlab? (There are > likely other issues I'd want to see addressed before this becomes > a common process.) Those are basically the reasons we decided to have a try. There is certainly a how-to needed for a submitter and some scripting to at least ping the maintainers. I have volunteered to send a series via gitlab as I had already this one in the works and the main maintainers of the modified files agreed to try the gitlab workflow. We need to learn whether this is something to consider or not, and for this purpose we need a practical example. TBH I had some reservations as I like to be able to review patches while being offline, so I want to make sure this is still possible somehow. And being part of the experiment ensures I'm not missing anything. :-) Juergen