From: "selvanair (Code Review)" Date: Tue, 31 Mar 2026 18:53:55 +0000 References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7z7pA0tSLs4="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Log when writing username/password to TLS buffer fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --7z7pA0tSLs4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1600?usp=3Demail to review the following change. Change subject: Log when writing username/password to TLS buffer fails ...................................................................... Log when writing username/password to TLS buffer fails Currently we get an unhelpful "Key Method #2 failed" error. Add a more specific warning message. Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Signed-off-by: Selva Nair --- M src/openvpn/ssl.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/00/1600/1 diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 576157d..5868d53 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -2125,10 +2125,12 @@ if (!write_string(buf, up->username, -1)) { + msg(M_WARN, "WARNING: Failed to write auth username to TLS buf= fer"); goto error; } else if (!write_string(buf, up->password, -1)) { + msg(M_WARN, "WARNING: Failed to write auth password to TLS buf= fer"); goto error; } /* save username for auth-token which may get pushed later */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1600?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Gerrit-Change-Number: 1600 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --7z7pA0tSLs4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

selvanair would like plaisthos to review this change.

V= iew Change

Log when writing username/password to TLS b=
uffer fails

Currently we get an unhelpful "Key Method #2 failed= " error.
Add a more specific warning message.

Change-Id: I94= 68811fd434e17645957fc12770aa2b9ed98fb8
Signed-off-by: Selva Nair <sel= va.nair@...277...>
---
M src/openvpn/ssl.c
1 file changed, 2 in= sertions(+), 0 deletions(-)

git pull ssh://gerri=
t.openvpn.net:29418/openvpn refs/changes/00/1600/1
diff --git a/src=
/openvpn/ssl.c b/src/openvpn/ssl.c
index 576157d..5868d53 1= 00644
--- a/src/openvpn/ssl.c
+++ b/src/ope= nvpn/ssl.c
@@ -2125,10 +2125,12 @@
=
if (!write_string(buf, up->username, -1))
<= span> {
+ = msg(M_WARN, "WARNING: Failed to write auth username to TLS buf= fer");
goto error;
= }
else if (!write_string(buf, up->password, = -1))
{
+ msg(M_WARN, "WARNING: Failed to write auth pas= sword to TLS buffer");
goto error;=
}
/* save username for auth-tok= en which may get pushed later */

To vie= w, visit change 1600. To unsubscribe, or for help writing mail filters, visit <= a href=3D"http://gerrit.openvpn.net/settings?usp=3Demail">settings.

=
<= meta itemprop=3D"name" content=3D"View Change"/>
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9468811fd434e17645957fc1277= 0aa2b9ed98fb8
Gerrit-Change-Number: 1600
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --7z7pA0tSLs4=--