From: "plaisthos (Code Review)" Date: Thu, 2 Apr 2026 10:56:52 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="oFwl4CDQ0k0="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --oFwl4CDQ0k0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.= openvpn.net/c/openvpn/+/1587?usp=3Demail ) Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certifica= te usage ...................................................................... Patch Set 4: (3 comments) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1587/comment/9c1d6b68_eba94285?usp=3D= email : PS4, Line 619: * Note that we do not check for netscape certificat= e type here but rather > This line of the comment appears to describe the check above? Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1587/comment/da852456_6bac570a?usp=3D= email : PS4, Line 620: * check for a gneral SSL/TLS client purpose. We do = not know how long nscert > general Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1587/comment/a5d1f69a_f10bf290?usp=3D= email : PS4, Line 621: * attributes are accepted by TLS library in the fut= ure. Currently OpenSSL 4.0 > libraries Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2 Gerrit-Change-Number: 1587 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 02 Apr 2026 10:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld --oFwl4CDQ0k0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld.

View = Change

3 comments:

  • File src/openvpn/ssl_verify_openss= l.c:

    • P= atch Set #4, Line 619: = * Note that we do not check for netscape certificate type here but= rather

      This line of the comment appears to describe = the check above?

      Acknowledged

    • Patch Set #4, Line 620: * check for a gneral SSL/TLS client purpose. We do not know how= long nscert

      general

      Acknowledged

    • Patch Set #4, Line 621: * attributes are accepted by TLS libr= ary in the future. Currently OpenSSL 4.0

      libraries

      Acknowledged

To view, visit change 1587. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca0= 7d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 02 Apr 2026 10:56:52= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
= --oFwl4CDQ0k0=--