From: Simon Goldschmidt Date: Fri, 3 May 2019 22:33:13 +0200 Subject: [U-Boot] [PATCH] cmd: reset: add parameters to specify reboot_mode In-Reply-To: References: <20190503202523.23423-1-simon.k.r.goldschmidt@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03.05.19 22:27, Marek Vasut wrote: > On 5/3/19 10:25 PM, Simon Goldschmidt wrote: >> This patch adds parameter support for the 'reset' command to specify >> the reboot mode (cold vs. warm). >> >> Checking these parameters is implemented in the DM implementation. >> >> Signed-off-by: Simon Goldschmidt >> --- >> >> cmd/boot.c | 4 ++-- >> drivers/sysreset/sysreset-uclass.c | 17 ++++++++++++++++- >> 2 files changed, 18 insertions(+), 3 deletions(-) >> >> diff --git a/cmd/boot.c b/cmd/boot.c >> index 9150fce80b..c3f33a9ca3 100644 >> --- a/cmd/boot.c >> +++ b/cmd/boot.c >> @@ -56,9 +56,9 @@ U_BOOT_CMD( >> #endif >> >> U_BOOT_CMD( >> - reset, 1, 0, do_reset, >> + reset, 2, 0, do_reset, >> "Perform RESET of the CPU", >> - "" >> + "[] - type of reboot" >> ); >> >> #ifdef CONFIG_CMD_POWEROFF >> diff --git a/drivers/sysreset/sysreset-uclass.c b/drivers/sysreset/sysreset-uclass.c >> index ad831c703a..fbda3f44f2 100644 >> --- a/drivers/sysreset/sysreset-uclass.c >> +++ b/drivers/sysreset/sysreset-uclass.c >> @@ -111,9 +111,24 @@ void reset_cpu(ulong addr) >> >> int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) >> { >> + enum sysreset_t reboot_mode = SYSRESET_COLD; >> + >> + if (argc > 1 && argv[1]) { >> + switch (*argv[1]) { >> + case 'w': >> + reboot_mode = SYSRESET_WARM; >> + printf("warm "); >> + break; >> + case 'c': >> + reboot_mode = SYSRESET_COLD; >> + printf("cold "); >> + break; > > This looks like a platform or driver specific stuff ? Ouch, I just saw the extra printf might have to be removed in a v2... Anyway, except for that, I don't think it's platform or driver specific. It's just a way to make the cmd 'reset' take arguments that map to enum sysreset_t. There is a problem in that other platforms without UCLASS_SYSRESET don't handle these arguments, but I thought UCLASS_SYSRESET would be the future, and the rest would be "legacy"? Regards, SImon