Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74EBDC433B4 for ; Mon, 17 May 2021 11:22:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3884761029 for ; Mon, 17 May 2021 11:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3884761029 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.128180.240685 (Exim 4.92) (envelope-from ) id 1libJy-0003zZ-6T; Mon, 17 May 2021 11:22:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 128180.240685; Mon, 17 May 2021 11:22:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1libJy-0003zS-3U; Mon, 17 May 2021 11:22:02 +0000 Received: by outflank-mailman (input) for mailman id 128180; Mon, 17 May 2021 11:22:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1libJw-0003zM-30 for xen-devel@lists.xenproject.org; Mon, 17 May 2021 11:22:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0fbc4c5a-d9e1-4eff-9e14-0f1028d77262; Mon, 17 May 2021 11:21:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 767D0B077; Mon, 17 May 2021 11:21:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fbc4c5a-d9e1-4eff-9e14-0f1028d77262 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621250518; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JqORidrnXvepoyATdPCMnKUTiaJhRNOhWnYZ8IcDbzI=; b=HNrWiRIppa3RD141YkyGccYkkVFB46DBdvuXAWCVFGlOZpPaQ7xNKbLWFYG88u3+mKxsFb Yjh/r8gxZe4ySbDbxZRRwQTgfs/k030O3bvnSjUZu8X2S1PcasJG6YJRFoLzJiqJP7b8U5 5T7bp/6w2b5ALjx1lzOH9Fi9thTq9LM= Subject: Re: [PATCH v3 3/5] xen: Fix build when !CONFIG_GRANT_TABLE To: Connor Davis Cc: Bobby Eshleman , Alistair Francis , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <834f7995ae80a3b37b6d508d1c989b4ee391f61b.1621017334.git.connojdavis@gmail.com> From: Jan Beulich Message-ID: Date: Mon, 17 May 2021 13:22:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <834f7995ae80a3b37b6d508d1c989b4ee391f61b.1621017334.git.connojdavis@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 14.05.2021 20:53, Connor Davis wrote: > Move struct grant_table; in grant_table.h above > ifdef CONFIG_GRANT_TABLE. This fixes the following: > > /build/xen/include/xen/grant_table.h:84:50: error: 'struct grant_table' > declared inside parameter list will not be visible outside of this > definition or declaration [-Werror] > 84 | static inline int mem_sharing_gref_to_gfn(struct grant_table *gt, > | There must be more to this, as e.g. the PV shim does get built with !GRANT_TABLE. Nevertheless, ... > Signed-off-by: Connor Davis ... since the potential of breaking the build is obvious enough, Acked-by: Jan Beulich Jan