Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4E2C10DCE for ; Thu, 12 Mar 2020 20:37:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9A642067C for ; Thu, 12 Mar 2020 20:37:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9A642067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 59BBA6E0C6; Thu, 12 Mar 2020 20:37:17 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C18C86E0C6 for ; Thu, 12 Mar 2020 20:37:15 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 13:37:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,545,1574150400"; d="scan'208";a="236976698" Received: from kneumaye-mobl2.ger.corp.intel.com (HELO [10.249.40.133]) ([10.249.40.133]) by orsmga008.jf.intel.com with ESMTP; 12 Mar 2020 13:37:13 -0700 To: "Dixit, Ashutosh" , Umesh Nerlige Ramappa References: <20200303221905.25866-1-umesh.nerlige.ramappa@intel.com> <20200303221905.25866-5-umesh.nerlige.ramappa@intel.com> <87tv2twezu.wl-ashutosh.dixit@intel.com> From: Lionel Landwerlin Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Message-ID: Date: Thu, 12 Mar 2020 22:37:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <87tv2twezu.wl-ashutosh.dixit@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 4/7] drm/i915/perf: add new open param to configure polling of OA buffer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 12/03/2020 21:27, Dixit, Ashutosh wrote: > On Tue, 03 Mar 2020 14:19:02 -0800, Umesh Nerlige Ramappa wrote: >> From: Lionel Landwerlin >> >> This new parameter let's the application choose how often the OA >> buffer should be checked on the CPU side for data availability. Longer >> polling period tend to reduce CPU overhead if the application does not >> care about somewhat real time data collection. >> >> v2: Allow disabling polling completely with 0 value (Lionel) >> v3: Version the new parameter (Joonas) >> v4: Rebase (Umesh) > Hi Lionel, I was thinking that one way to keep things simple for now (and > fix the high cpu usage issue) would be to expose _ONLY_ this OA poll period > parameter to user space. That is we don't expose the interrupt or the flush > ioctl to user space at this time. This way the user will be able to > configure the hrtimer frequency to a lower value to bring down the cpu > usage. > > Also we would disallow disabling the timer (and internally also not use the > interrupt). So everything will happen in exactly the same way as it used to > (no other changes needed) but at a lower rate if the user so chooses. > > What do you think about this? > > Thanks! > -- > Ashutosh Sure, just make sure the users know about this. The fact that they can now select timer values that will potentially lead to the loss of the buffer's data because it was overridden. Thanks, -Lionel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx