Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 363B3C77B60 for ; Thu, 27 Apr 2023 00:37:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 918B1862CC; Thu, 27 Apr 2023 02:37:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 07FCA86375; Thu, 27 Apr 2023 02:37:54 +0200 (CEST) Received: from mail-m118111.qiye.163.com (mail-m118111.qiye.163.com [115.236.118.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 30D4B862C3 for ; Thu, 27 Apr 2023 02:37:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [192.168.60.65] (unknown [103.29.142.67]) by mail-m118111.qiye.163.com (Hmail) with ESMTPA id 6D673580460; Thu, 27 Apr 2023 08:37:39 +0800 (CST) Message-ID: Date: Thu, 27 Apr 2023 08:37:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY Content-Language: en-US To: Eugen Hristev , u-boot@lists.denx.de Cc: jonas@kwiboo.se, jagan@edgeble.ai, Joseph Chen References: <20230426155319.148707-1-eugen.hristev@collabora.com> <20230426155319.148707-5-eugen.hristev@collabora.com> From: Kever Yang In-Reply-To: <20230426155319.148707-5-eugen.hristev@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlCSUxDVkJMHk8ZTxkaTx5NQ1UTARMWGhIXJBQOD1 lXWRgSC1lBWUpLSFVJQlVKT0lVTUxZV1kWGg8SFR0UWUFZT0tIVUpKS0hKTFVKS0tVS1kG X-HM-Tid: 0a87c024f31b2eb7kusn6d673580460 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Kxg6OAw4FD0XQ0oYFxAXODc4 IQgaCgtVSlVKTUNJTk5OQ01LT0tMVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlKS0hVSUJVSk9JVU1MWVdZCAFZQU5CQ0o3Bg++ X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Eugen, On 2023/4/26 23:53, Eugen Hristev wrote: > From: Joseph Chen > > Add the node for pciE 2x1l 2 device together with the corresponding Typo "pciE" in the patch 5-7? We use 'PCIe' in term or 'pcie' in code. Thanks, - Kever > combphy. > > Signed-off-by: Joseph Chen > [eugen.hristev@collabora.com: moved to -u-boot.dtsi, minor > adaptations] > Signed-off-by: Eugen Hristev > [jonas@kwiboo.se: adapt to kernel node] > Signed-off-by: Jonas Karlman > --- > Changes in v2: > - add compliance with linux by Jonas > > arch/arm/dts/rk3588s-u-boot.dtsi | 77 ++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi > index ad652c02e58e..6385da1471a5 100644 > --- a/arch/arm/dts/rk3588s-u-boot.dtsi > +++ b/arch/arm/dts/rk3588s-u-boot.dtsi > @@ -4,6 +4,7 @@ > */ > > #include "rockchip-u-boot.dtsi" > +#include > > / { > dmc { > @@ -58,6 +59,11 @@ > reg = <0x0 0xfd58a000 0x0 0x2000>; > }; > > + pipe_phy0_grf: syscon@fd5bc000 { > + compatible = "rockchip,pipe-phy-grf", "syscon"; > + reg = <0x0 0xfd5bc000 0x0 0x100>; > + }; > + > usb2phy2_grf: syscon@fd5d8000 { > compatible = "rockchip,rk3588-usb2phy-grf", "syscon", > "simple-mfd"; > @@ -104,6 +110,61 @@ > }; > }; > > + pcie2x1l2: pcie@fe190000 { > + compatible = "rockchip,rk3588-pcie", "snps,dw-pcie"; > + #address-cells = <3>; > + #size-cells = <2>; > + bus-range = <0x40 0x4f>; > + clocks = <&cru ACLK_PCIE_1L2_MSTR>, <&cru ACLK_PCIE_1L2_SLV>, > + <&cru ACLK_PCIE_1L2_DBI>, <&cru PCLK_PCIE_1L2>, > + <&cru CLK_PCIE_AUX4>, <&cru CLK_PCIE1L2_PIPE>; > + clock-names = "aclk_mst", "aclk_slv", > + "aclk_dbi", "pclk", > + "aux", "pipe"; > + device_type = "pci"; > + interrupts = , > + , > + , > + , > + ; > + interrupt-names = "sys", "pmc", "msg", "legacy", "err"; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0 0 0 1 &pcie2x1l2_intc 0>, > + <0 0 0 2 &pcie2x1l2_intc 1>, > + <0 0 0 3 &pcie2x1l2_intc 2>, > + <0 0 0 4 &pcie2x1l2_intc 3>; > + linux,pci-domain = <4>; > + num-ib-windows = <8>; > + num-ob-windows = <8>; > + num-viewport = <4>; > + max-link-speed = <2>; > + msi-map = <0x4000 &gic 0x4000 0x1000>; > + num-lanes = <1>; > + phys = <&combphy0_ps PHY_TYPE_PCIE>; > + phy-names = "pcie-phy"; > + power-domains = <&power RK3588_PD_PCIE>; > + ranges = <0x01000000 0x0 0xf4100000 0x0 0xf4100000 0x0 0x00100000>, > + <0x02000000 0x0 0xf4200000 0x0 0xf4200000 0x0 0x00e00000>, > + <0x03000000 0x0 0x40000000 0xa 0x00000000 0x0 0x40000000>; > + reg = <0xa 0x41000000 0x0 0x00400000>, > + <0x0 0xfe190000 0x0 0x00010000>, > + <0x0 0xf4000000 0x0 0x00100000>; > + reg-names = "dbi", "apb", "config"; > + resets = <&cru SRST_PCIE4_POWER_UP>, <&cru SRST_P_PCIE4>; > + reset-names = "pcie", "periph"; > + rockchip,pipe-grf = <&php_grf>; > + status = "disabled"; > + > + pcie2x1l2_intc: legacy-interrupt-controller { > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <1>; > + interrupt-parent = <&gic>; > + interrupts = ; > + }; > + }; > + > sfc: spi@fe2b0000 { > compatible = "rockchip,sfc"; > reg = <0x0 0xfe2b0000 0x0 0x4000>; > @@ -134,6 +195,22 @@ > reg = <0x0 0xfe378000 0x0 0x200>; > status = "disabled"; > }; > + > + combphy0_ps: phy@fee00000 { > + compatible = "rockchip,rk3588-naneng-combphy"; > + reg = <0x0 0xfee00000 0x0 0x100>; > + #phy-cells = <1>; > + clocks = <&cru CLK_REF_PIPE_PHY0>, <&cru PCLK_PCIE_COMBO_PIPE_PHY0>, > + <&cru PCLK_PHP_ROOT>; > + clock-names = "refclk", "apbclk", "phpclk"; > + assigned-clocks = <&cru CLK_REF_PIPE_PHY0>; > + assigned-clock-rates = <100000000>; > + resets = <&cru SRST_P_PCIE2_PHY0>, <&cru SRST_REF_PIPE_PHY0>; > + reset-names = "combphy-apb", "combphy"; > + rockchip,pipe-grf = <&php_grf>; > + rockchip,pipe-phy-grf = <&pipe_phy0_grf>; > + status = "disabled"; > + }; > }; > > &xin24m {