Message-ID: Date: Tue, 31 Jan 2006 21:50:25 +0200 From: Dmitry Adamushko Subject: Re: [Xenomai-core] [PATCH] Shared irqs v.6 In-Reply-To: <43DFB5F9.50406@domain.hid> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_23465_19887500.1138737025170" References: <43DFB5F9.50406@domain.hid> List-Id: "Xenomai life and development \(bug reports, patches, discussions\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: xenomai@xenomai.org ------=_Part_23465_19887500.1138737025170 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On 31/01/06, Jan Kiszka wrote: > > Dmitry Adamushko wrote: > > Hi, > > > > the previous version contained an ugly bug, namely the misuse of the > > test_and_set/clear_bit interface > > that led to a broken system from time to time. > > > > What about the ISA/edge-triggered stuff? :D > > My problem is that we cannot test here on real hardware because all our > shared IRQs reside on PC104 cards. Could you provide me with some real piece of such code as an example? Anyway, design-wise, it's about introducing a separate xnintr_handler() for such a special case to avoid getting a mixture with the rest of "sane" code= . I mean that the support of shared interrupts for ISA boards (edge-triggered stuff) is a kind of emulation to overcome the shortcommings of the initial design on the hardware level. The hardware was just not supposed to support shared interrupt channels. So, let's keep it a bit aside from another code :o) xnintr_attach() will check for a special flag like XN_ISR_ISASHARED and attach e.g. xnintr_isairq_handler() instead of xnintr_irq_handler(). I'll post an extension to the rt_intr_create(..., const char *name, ...) tomorrow - made but not tested yet - as well as the /proc support. Jan > -- Best regards, Dmitry Adamushko ------=_Part_23465_19887500.1138737025170 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On 31/01/06, Jan Kiszka <jan.kiszka@domain.hid= .de> wrote:
Dmitry Adamushko wrote:
> Hi,
>
> the previous version co= ntained an ugly bug, namely the misuse of the
> test_and_set/clear_bi= t interface
> that led to a broken system from time to time.
>

What about the ISA/edge-triggered stuff? :D

My problem is th= at we cannot test here on real hardware because all our
shared IRQs resi= de on PC104 cards.

Could you provide me with some real piece of such code as an example?

Anyway, design-wise, it's about introducing a separate xnintr_handler() for such a special case to avoid getting a mixture with the rest of "sane" code. I mean that the support of shared interrupts for ISA boards (edge-triggered stuff) is a kind of emulation to overcome the shortcommings of the initial design on the hardware level. The hardware was just not supposed to support shared interrupt channels. So, let's keep it a bit aside from another code :o)

xnintr_attach() will check for a special flag like XN_ISR_ISASHARED and attach e.g. xnintr_isairq_handler() instead of xnintr_irq_handler().
 
I'll post an extension to the rt_intr_create(..., const char *name, ...) to= morrow - made but not tested yet -

as well as the /proc support.


Jan
=


--
Best regards,
Dmitry Ada= mushko

------=_Part_23465_19887500.1138737025170--