From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/3] drm/amdgpu: only enable swiotlb alloc when need Date: Thu, 8 Feb 2018 09:07:33 +0100 Message-ID: References: <20180208060017.30780-1-david1.zhou@amd.com> <20180208060017.30780-2-david1.zhou@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0075.outbound.protection.outlook.com [104.47.41.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AAA96E40C for ; Thu, 8 Feb 2018 08:07:50 +0000 (UTC) In-Reply-To: <20180208060017.30780-2-david1.zhou@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMDguMDIuMjAxOCB1bSAwNzowMCBzY2hyaWViIENodW5taW5nIFpob3U6Cj4gZ2V0IHRoZSBt YXggaW8gbWFwcGluZyBhZGRyZXNzIG9mIHN5c3RlbSBtZW1vcnkgdG8gc2VlIGlmIGl0IGlzIG92 ZXIKPiBvdXIgY2FyZCBhY2Nlc3NpbmcgcmFuZ2UuCj4KPiBDaGFuZ2UtSWQ6IEliYzM4ZGJkMzRh MjBhZjViNGE0YjFlZDE1NGMxNGUxYzU4YWE0YzU1Cj4gU2lnbmVkLW9mZi1ieTogQ2h1bm1pbmcg WmhvdSA8ZGF2aWQxLnpob3VAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdS5oICAgICB8IDEgKwo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X3R0bS5jIHwgNiArKystLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dt Y192Nl8wLmMgICB8IDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192N18w LmMgICB8IDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192OF8wLmMgICB8 IDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192OV8wLmMgICB8IDIgKysK PiAgIDYgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaCBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gaW5kZXggMjU3NDI0ZGQ4YTUyLi42Mjdh MDYxODUzNjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+IEBAIC0xNDM3 LDYgKzE0MzcsNyBAQCBzdHJ1Y3QgYW1kZ3B1X2RldmljZSB7Cj4gICAJY29uc3Qgc3RydWN0IGFt ZGdwdV9hc2ljX2Z1bmNzCSphc2ljX2Z1bmNzOwo+ICAgCWJvb2wJCQkJc2h1dGRvd247Cj4gICAJ Ym9vbAkJCQluZWVkX2RtYTMyOwo+ICsJYm9vbAkJCQluZWVkX3N3aW90bGI7Cj4gICAJYm9vbAkJ CQlhY2NlbF93b3JraW5nOwo+ICAgCXN0cnVjdCB3b3JrX3N0cnVjdAkJcmVzZXRfd29yazsKPiAg IAlzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sJCWFjcGlfbmI7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV90dG0uYwo+IGluZGV4IDk1Zjk5MDE0MGYyYS4uYTAyMWRlOTYyOWFkIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+IEBAIC0xMDE4LDcgKzEw MTgsNyBAQCBzdGF0aWMgaW50IGFtZGdwdV90dG1fdHRfcG9wdWxhdGUoc3RydWN0IHR0bV90dCAq dHRtLAo+ICAgCX0KPiAgIAo+ICAgI2lmZGVmIENPTkZJR19TV0lPVExCCj4gLQlpZiAoc3dpb3Rs Yl9ucl90YmwoKSkgewo+ICsJaWYgKGFkZXYtPm5lZWRfc3dpb3RsYiAmJiBzd2lvdGxiX25yX3Ri bCgpKSB7Cj4gICAJCXJldHVybiB0dG1fZG1hX3BvcHVsYXRlKCZndHQtPnR0bSwgYWRldi0+ZGV2 LCBjdHgpOwo+ICAgCX0KPiAgICNlbmRpZgo+IEBAIC0xMDQ1LDcgKzEwNDUsNyBAQCBzdGF0aWMg dm9pZCBhbWRncHVfdHRtX3R0X3VucG9wdWxhdGUoc3RydWN0IHR0bV90dCAqdHRtKQo+ICAgCWFk ZXYgPSBhbWRncHVfdHRtX2FkZXYodHRtLT5iZGV2KTsKPiAgIAo+ICAgI2lmZGVmIENPTkZJR19T V0lPVExCCj4gLQlpZiAoc3dpb3RsYl9ucl90YmwoKSkgewo+ICsJaWYgKGFkZXYtPm5lZWRfc3dp b3RsYiAmJiBzd2lvdGxiX25yX3RibCgpKSB7Cj4gICAJCXR0bV9kbWFfdW5wb3B1bGF0ZSgmZ3R0 LT50dG0sIGFkZXYtPmRldik7Cj4gICAJCXJldHVybjsKPiAgIAl9Cj4gQEAgLTIwMDcsNyArMjAw Nyw3IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3R0bV9kZWJ1Z2ZzX2luaXQoc3RydWN0IGFtZGdwdV9k ZXZpY2UgKmFkZXYpCj4gICAJY291bnQgPSBBUlJBWV9TSVpFKGFtZGdwdV90dG1fZGVidWdmc19s aXN0KTsKPiAgIAo+ICAgI2lmZGVmIENPTkZJR19TV0lPVExCCj4gLQlpZiAoIXN3aW90bGJfbnJf dGJsKCkpCj4gKwlpZiAoIShhZGV2LT5uZWVkX3N3aW90bGIgJiYgc3dpb3RsYl9ucl90YmwoKSkp Cj4gICAJCS0tY291bnQ7Cj4gICAjZW5kaWYKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9nbWNfdjZfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv Z21jX3Y2XzAuYwo+IGluZGV4IDVlYWNjMDgxOWI2Ni4uNjNkMDcyMGFjMjFmIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192Nl8wLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjZfMC5jCj4gQEAgLTIyLDYgKzIyLDcgQEAKPiAgICAq Lwo+ICAgI2luY2x1ZGUgPGxpbnV4L2Zpcm13YXJlLmg+Cj4gICAjaW5jbHVkZSA8ZHJtL2RybVAu aD4KPiArI2luY2x1ZGUgPGRybS9kcm1fY2FjaGUuaD4KPiAgICNpbmNsdWRlICJhbWRncHUuaCIK PiAgICNpbmNsdWRlICJnbWNfdjZfMC5oIgo+ICAgI2luY2x1ZGUgImFtZGdwdV91Y29kZS5oIgo+ IEBAIC04NTUsNiArODU2LDcgQEAgc3RhdGljIGludCBnbWNfdjZfMF9zd19pbml0KHZvaWQgKmhh bmRsZSkKPiAgIAo+ICAgCWFkZXYtPm5lZWRfZG1hMzIgPSBmYWxzZTsKPiAgIAlkbWFfYml0cyA9 IGFkZXYtPm5lZWRfZG1hMzIgPyAzMiA6IDQwOwo+ICsJYWRldi0+bmVlZF9zd2lvdGxiID0gZHJt X2dldF9tYXhfaW9tZW0oKSA+ICgodTY0KTEgPDwgZG1hX2JpdHMpOwoKVGhlIGNvZGUgaGVyZSBp cyBtaXhlZCB1cC4gVGhlIGNoZWNrIG5lZWRzIHRvIGNvbWUgbGF0ZXIsIGFmdGVyIHdlIHRyaWVk IAp0byBzZXQgdGhlIGRtYV9tYXNrIGFuZCBwb3NzaWJsZSBmYWlsZWQuCgpTYW1lIGZvciBhbGwg b3RoZXIgR01DIHZhcmlhbnRzIGFzIHdlbGwuCgpBcGFydCBmcm9tIHRoYXQgdGhlIHNlcmllcyBs b29rcyBnb29kIHRvIG1lLApDaHJpc3RpYW4uCgo+ICAgCXIgPSBwY2lfc2V0X2RtYV9tYXNrKGFk ZXYtPnBkZXYsIERNQV9CSVRfTUFTSyhkbWFfYml0cykpOwo+ICAgCWlmIChyKSB7Cj4gICAJCWFk ZXYtPm5lZWRfZG1hMzIgPSB0cnVlOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9nbWNfdjdfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y3XzAu Ywo+IGluZGV4IGNlN2Y0ODRmODZmOS4uZjcwYTgxZmNhZGVjIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192N18wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9nbWNfdjdfMC5jCj4gQEAgLTIyLDYgKzIyLDcgQEAKPiAgICAqLwo+ICAgI2lu Y2x1ZGUgPGxpbnV4L2Zpcm13YXJlLmg+Cj4gICAjaW5jbHVkZSA8ZHJtL2RybVAuaD4KPiArI2lu Y2x1ZGUgPGRybS9kcm1fY2FjaGUuaD4KPiAgICNpbmNsdWRlICJhbWRncHUuaCIKPiAgICNpbmNs dWRlICJjaWtkLmgiCj4gICAjaW5jbHVkZSAiY2lrLmgiCj4gQEAgLTEwMDMsNiArMTAwNCw3IEBA IHN0YXRpYyBpbnQgZ21jX3Y3XzBfc3dfaW5pdCh2b2lkICpoYW5kbGUpCj4gICAJICovCj4gICAJ YWRldi0+bmVlZF9kbWEzMiA9IGZhbHNlOwo+ICAgCWRtYV9iaXRzID0gYWRldi0+bmVlZF9kbWEz MiA/IDMyIDogNDA7Cj4gKwlhZGV2LT5uZWVkX3N3aW90bGIgPSBkcm1fZ2V0X21heF9pb21lbSgp ID4gKCh1NjQpMSA8PCBkbWFfYml0cyk7Cj4gICAJciA9IHBjaV9zZXRfZG1hX21hc2soYWRldi0+ cGRldiwgRE1BX0JJVF9NQVNLKGRtYV9iaXRzKSk7Cj4gICAJaWYgKHIpIHsKPiAgIAkJYWRldi0+ bmVlZF9kbWEzMiA9IHRydWU7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2dtY192OF8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjhfMC5jCj4g aW5kZXggZjUzZjM5MzZmZDRmLi4yMWZlOWFmYjZlNzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y4XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2dtY192OF8wLmMKPiBAQCAtMjIsNiArMjIsNyBAQAo+ICAgICovCj4gICAjaW5jbHVk ZSA8bGludXgvZmlybXdhcmUuaD4KPiAgICNpbmNsdWRlIDxkcm0vZHJtUC5oPgo+ICsjaW5jbHVk ZSA8ZHJtL2RybV9jYWNoZS5oPgo+ICAgI2luY2x1ZGUgImFtZGdwdS5oIgo+ICAgI2luY2x1ZGUg ImdtY192OF8wLmgiCj4gICAjaW5jbHVkZSAiYW1kZ3B1X3Vjb2RlLmgiCj4gQEAgLTExMDEsNiAr MTEwMiw3IEBAIHN0YXRpYyBpbnQgZ21jX3Y4XzBfc3dfaW5pdCh2b2lkICpoYW5kbGUpCj4gICAJ ICovCj4gICAJYWRldi0+bmVlZF9kbWEzMiA9IGZhbHNlOwo+ICAgCWRtYV9iaXRzID0gYWRldi0+ bmVlZF9kbWEzMiA/IDMyIDogNDA7Cj4gKwlhZGV2LT5uZWVkX3N3aW90bGIgPSBkcm1fZ2V0X21h eF9pb21lbSgpID4gKCh1NjQpMSA8PCBkbWFfYml0cyk7Cj4gICAJciA9IHBjaV9zZXRfZG1hX21h c2soYWRldi0+cGRldiwgRE1BX0JJVF9NQVNLKGRtYV9iaXRzKSk7Cj4gICAJaWYgKHIpIHsKPiAg IAkJYWRldi0+bmVlZF9kbWEzMiA9IHRydWU7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2dtY192OV8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNf djlfMC5jCj4gaW5kZXggMmM2MDk4MWQyZWVjLi44NzMwNzY4ZWZkMTMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2dtY192OV8wLmMKPiBAQCAtMjEsNiArMjEsNyBAQAo+ICAgICoKPiAg ICAqLwo+ICAgI2luY2x1ZGUgPGxpbnV4L2Zpcm13YXJlLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJt X2NhY2hlLmg+Cj4gICAjaW5jbHVkZSAiYW1kZ3B1LmgiCj4gICAjaW5jbHVkZSAiZ21jX3Y5XzAu aCIKPiAgICNpbmNsdWRlICJhbWRncHVfYXRvbWZpcm13YXJlLmgiCj4gQEAgLTg3OSw2ICs4ODAs NyBAQCBzdGF0aWMgaW50IGdtY192OV8wX3N3X2luaXQodm9pZCAqaGFuZGxlKQo+ICAgCSAqLwo+ ICAgCWFkZXYtPm5lZWRfZG1hMzIgPSBmYWxzZTsKPiAgIAlkbWFfYml0cyA9IGFkZXYtPm5lZWRf ZG1hMzIgPyAzMiA6IDQ0Owo+ICsJYWRldi0+bmVlZF9zd2lvdGxiID0gZHJtX2dldF9tYXhfaW9t ZW0oKSA+ICgodTY0KTEgPDwgZG1hX2JpdHMpOwo+ICAgCXIgPSBwY2lfc2V0X2RtYV9tYXNrKGFk ZXYtPnBkZXYsIERNQV9CSVRfTUFTSyhkbWFfYml0cykpOwo+ICAgCWlmIChyKSB7Cj4gICAJCWFk ZXYtPm5lZWRfZG1hMzIgPSB0cnVlOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==