Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF7F9C00140 for ; Mon, 8 Aug 2022 12:52:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 63B1C84194; Mon, 8 Aug 2022 14:52:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1659963124; bh=zzLMKv0K6lY5QgoW6CvIMFsXA67pXNspOAm58tx88U8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kgRK3xV00DNqO/L5xfB3scaMhJ1hY4CgCy/eDGLf8mzEImlF4vcT8XU/dAcQYYSgy InvsLzqb3PU5bfLVE+UiRwDs7+dtvX2OEhfdccor4sHIAdaYFM+LQEoVC4SCenH+hQ VEYT8e8Y3cB7NfHVmXrNN/y569XlHy9sHcfCr2bml5szF5qnRAFDRRhA/hSAcF5jwz 3/xOVn4rWdoTerQpHv78QR6PaFr7ELjMud9S4p70bihDh2vNS6lgajYw/mUsrBXhd2 4C1TwW1OR7d5d8wSGPsQBKeMLRh6kNCCaCAyrliEsqCreQgGpoVNsUaxa8TgD/GoHr ux6V/qSl3pa5A== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9D6BD8400E; Mon, 8 Aug 2022 14:52:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1659963123; bh=zzLMKv0K6lY5QgoW6CvIMFsXA67pXNspOAm58tx88U8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UAqtM7gjyX0Jcw99pxpLBSnJHWJIgravrHiPDtrN1lBxWmoGQOTNGU9gLnM7cFa4i PMT8n2dU/hmKxdjP+1dLODH6spvFFp0WFQDQM9iljp01/CMd8tYB/qj0V15+eRZyrk 8kI1kxoLnAdu9M09zbQsiIihjMMK1F4yNBDUu2/TDDJIGs4gTyhijvb6vE0HLjG6Z9 lwrYECgVdlGVxz0R44zvT+e22XWo/Mdz9OlLoINwfwknIhFMHGe7aAymjjRjDGpTaU yGqk5VUB2nIT/55wDWZs3U7RoVxeVSvEXqZG4lm9go9IIFa5VS7x/9WkJxkjvla2E1 eLiez3EOI51VQ== Message-ID: Date: Mon, 8 Aug 2022 14:52:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 1/2] ARM: cache: Allow SPL to build cache-pl310.c Content-Language: en-US To: Philip Oberfichtner , Tom Rini Cc: u-boot@lists.denx.de, Christoph Niedermaier , Stefano Babic , Dzmitry Sankouski , Sean Anderson , Stefan Roese References: <20220804105646.2285428-1-pro@denx.de> <20220804110527.GY1146598@bill-the-cat> <45d5b4eb9e81a074377cfeefa520a7b315d77f53.camel@denx.de> From: Marek Vasut In-Reply-To: <45d5b4eb9e81a074377cfeefa520a7b315d77f53.camel@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/8/22 14:29, Philip Oberfichtner wrote: > > > On Thu, 2022-08-04 at 07:05 -0400, Tom Rini wrote: >> On Thu, Aug 04, 2022 at 12:56:45PM +0200, Philip Oberfichtner wrote: >> >>> Before this commit, the SPL could enable the PL310 L2 cache [1], >>> but the >>> cache maintenance functions from cache-pl310.c were only useable >>> for >>> non-SPL builds. >>> >>> After enabling the cache one must be able to flush it, too. Thus >>> this >>> commit allows cache-pl310.c to be included in the SPL build. >>> >>> [1] See for example arch/arm/mach-imx/cache.c: >>> v7_outer_cache_enable() >>> >>> Signed-off-by: Philip Oberfichtner >> >> It should be rather direct to migrate this to Kconfig, please do that >> first, and introduce CONFIG_SPL_SYS_L2_PL310. Thanks! >> > > Hi, > > converting CONFIG_SYS_L2_PL310 - no problem. For SYS_PL310_BASE the > moveconfig tool just hangs indefinitely on every defconfig that needs > conversion. Do you have any hints on this issue? > > Below the Kconfig entry, that I used. > > config SYS_PL310_BASE > depends on SYS_L2_PL310 > hex "Base address of PL310" Try adding default values for known architectures/socs (use git grep in include/configs/ and sort -u to find out) default 0x1234ab00 if ARCH_FOO default 0x4321cd00 if ARCH_BAR > help > Physical base address of PL310 controller register space