From: "cron2 (Code Review)" Date: Thu, 30 Jan 2025 18:13:20 +0000 References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="OcxkluBt6mU="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/SITNL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --OcxkluBt6mU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=3Demail to review the following change. Change subject: get_default_gateway(): implement platform support for Linux= /SITNL ...................................................................... get_default_gateway(): implement platform support for Linux/SITNL This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f. Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c Signed-off-by: Gert Doering --- M src/openvpn/route.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/83/883/1 diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3501e35..3605671 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3333,7 +3333,7 @@ CLEAR(best_name); /* get default gateway IP addr */ - if (net_route_v4_best_gw(ctx, NULL, &rgi->gateway.addr, best_name) =3D= =3D 0) + if (net_route_v4_best_gw(ctx, &dest, &rgi->gateway.addr, best_name) = =3D=3D 0) { rgi->flags |=3D RGI_ADDR_DEFINED; if (!rgi->gateway.addr && best_name[0]) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c Gerrit-Change-Number: 883 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --OcxkluBt6mU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

cron2 would like plaisthos and flichtenheld to review t= his change.

Vi= ew Change

get_default_gateway(): implement platform support for Linux/S=
ITNL

This adds Linux/SITNL platform functionality to the framework s= tarted by
commit 9df51cf56 and commit 0fcfc8381f.

Change-Id: I1db= 72d7dca648a8ea4ec65d173290a819971305c
Signed-off-by: Gert Doering <ge= rt@...1296...>
---
M src/openvpn/route.c
1 file changed, 1 inse= rtion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/o=
penvpn refs/changes/83/883/1
diff --git a/src/openvpn/route.c b/src=
/openvpn/route.c
index 3501e35..3605671 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -3333,7 +3333,7 @@
CLEAR(best_name);

/* get default gateway IP addr */
- if (net_route_v4_best= _gw(ctx, NULL, &rgi->gateway.addr, best_name) =3D=3D 0)
+ if (net_route_v4_best_gw(ctx= , &dest, &rgi->gateway.addr, best_name) =3D=3D 0)

{

rgi->flags |=3D RGI_ADDR_DEFINED;
if (!rgi->gateway.addr && best_name[0])

To view, visit change 883. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d1732= 90a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--OcxkluBt6mU=--