Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25DFBC001DE for ; Mon, 24 Jul 2023 08:53:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E5F18682A; Mon, 24 Jul 2023 10:53:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="fZHdAmKI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1A1298684C; Mon, 24 Jul 2023 10:53:03 +0200 (CEST) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B7EDD867E0 for ; Mon, 24 Jul 2023 10:53:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=eugen.hristev@collabora.com Received: from [192.168.0.125] (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id EFD856607029; Mon, 24 Jul 2023 09:52:59 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690188780; bh=jGPRh/Ou+WKqxrQpp0gm1XTKwutsffa2DITdwMX2GHY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fZHdAmKILBJ7ptkZf8RTpRF0/R3upy7QJ2h/ABhCdRXBQFlUqDSCocIQe+YS+iwxy oCjq6E/qhFadhi0ebxygJ/t4fZLw9seQVYNKgxuoyClod4GGR3syt+VLAkSJKRl2Fh itO8MtcWU0SdlFdIq4voypfMpqh3Tjvyp+CnVsmHcjcErrRU0tsHDE+QTdCgDdptR/ kFfK7Flu1gM6ZCC01nnIymb51h6Xfr14WVuM1G+KlAPQCFKnnHs8GzwY0Ya7SPpxUv orsnab4KZTUCZ9tis0N46pgT4EpVwQNyT2PtqjaB00iqDVIX3lnqLtKGFPRLeOwHm4 w4GXEtZo4x48w== Message-ID: Date: Mon, 24 Jul 2023 11:52:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity Content-Language: en-US To: Mihai.Sain@microchip.com, u-boot@lists.denx.de Cc: Cristian.Birsan@microchip.com References: <20230720075448.23112-1-mihai.sain@microchip.com> <2643d6f7-03c7-3252-cf2c-215ac5fb7993@collabora.com> From: Eugen Hristev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/24/23 11:49, Mihai.Sain@microchip.com wrote: > Hello Eugen, > > Thank you for applying the patch. > > For this board we don't want to use SPL. > I will send v2 patch to remove the custom prompt. > Thanks. As I said, I won't be applying any patches to at91 tree unless someone helps with the testing below. SPL for this board has nothing to do with my request. These also have to be removed: + +#define CONFIG_SYS_SDRAM_BASE 0x20000000 +#define CONFIG_SYS_SDRAM_SIZE 0x20000000 as they are forbidden to set in the config file and appear to be unused anyway. Eugen > > Best regards, > Mihai Sain > > -----Original Message----- > From: Eugen Hristev > Sent: Monday, July 24, 2023 11:13 AM > To: Mihai Sain - M19926 ; u-boot@lists.denx.de > Cc: Cristian Birsan - M91496 > Subject: Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hello Mihai, > > Thank you for the patch. > > However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow. > There is a pending patch that fixes it, but it has not been tested. > Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) : > > https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads > > Once this is tested you can reply with a Tested-by: tag, and we can move along. > Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled. > > One small nitpick below, and I am looking forward for your reply, > > Eugen > > > On 7/20/23 10:54, Mihai Sain wrote: >> Add initial support for sama5d29_curiosity board. >> >> Hardware: >> SoC: SAMA5D29 500 MHz >> DRAM: LPDDR2 512 MiB >> PMIC: MCP16502 >> Debug: UART0 >> Flash: QSPI NOR 8 MiB >> RGB LCD connector >> Mikrobus connectors x 2 >> SD-Card connectors x 2 >> USB 2.0 x 2 >> >> Signed-off-by: Mihai Sain >> --- > >> +CONFIG_SYS_PROMPT="[root@sama5d29 ~]$ " > > Can you remove this. It looks like a Linux prompt and might be confusing for people > > (and everywhere below)