Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B437BC4338F for ; Wed, 25 Aug 2021 10:38:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B07E60C3E for ; Wed, 25 Aug 2021 10:38:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B07E60C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DE3256B006C; Wed, 25 Aug 2021 06:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D92D76B0071; Wed, 25 Aug 2021 06:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C812B8D0001; Wed, 25 Aug 2021 06:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id AB7F36B006C for ; Wed, 25 Aug 2021 06:38:36 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4D0E31802E609 for ; Wed, 25 Aug 2021 10:38:36 +0000 (UTC) X-FDA: 78513254232.05.16683F2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id E926C90000B4 for ; Wed, 25 Aug 2021 10:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629887915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPhLQzFs1IrHbkV/9CrSlj9c2Z4dRyx+Gb5Xtw/oGVE=; b=AZkF9MDPv4/qxwsfeacgnk/u/Oetx7ECP0CR/1lDZd7xYQLg51exHikeYL+mDG6cEGauNr BaveUlpXTpING8InthIdttM99EREuWfOmjyVFK//YPAVFMcuJHfvKJa2Z6N0oY7fxbU0PR iAgEvvbIPS/Z7nAnfShXCZD+5SfvD08= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-594-PsXqxvUpOeaODYFE326inQ-1; Wed, 25 Aug 2021 06:38:34 -0400 X-MC-Unique: PsXqxvUpOeaODYFE326inQ-1 Received: by mail-wm1-f70.google.com with SMTP id z186-20020a1c7ec30000b02902e6a27a9962so2666986wmc.3 for ; Wed, 25 Aug 2021 03:38:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=hPhLQzFs1IrHbkV/9CrSlj9c2Z4dRyx+Gb5Xtw/oGVE=; b=NBUKtxuii2ggy+Kke9yOhPuaa2xu/3Rc0ifFrlOtC9YXlb3x3a06UoudZ+BLxmobS8 KNORbJE0c9PmBQGxgxOPuvZfLMdJzm1aLzNeQqPuC+Om8oeTitE0/GrKGLMpNxCAvm4F xTOBVntIufzRYBT7EFdZiD8O8JSCUs1ksIk2d/uRsDCW7zwxxqY3t0BkP5dgbHSirudb 1l50pzEqnGBcynSdEnuL52k6NELaM7pcyAdxyNGn5A9nRL8VtcXtqJ0/m3mgv9eeJABP NPnhNzFWFT+ZKRNGz9WHgDJz5mWlpPgVdiB2PDJjQob8CF6FA05JLmFiv00XTINm7/Dg avDw== X-Gm-Message-State: AOAM530HVgc7Xi2KGwAKuDLwljD8Reo6XbwpIzVvbUED5jTsSFC/dKTS kYMho9+Du96bxw3um1kFOIxH4fH7mMw5SQZChPRKFe4+lKz9ind3kG7Ywn0IzVDrJj9IIvl+lHI 2k506RIn6SLw= X-Received: by 2002:a5d:6108:: with SMTP id v8mr24181222wrt.96.1629887912986; Wed, 25 Aug 2021 03:38:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGNOFKS+R2HIyOFowqXEX/I3jbojh7R9LnbeYwTVlgB8OSRLh2dCFN9VvnwzOlVy2nSxv7/A== X-Received: by 2002:a5d:6108:: with SMTP id v8mr24181191wrt.96.1629887912721; Wed, 25 Aug 2021 03:38:32 -0700 (PDT) Received: from [192.168.3.132] (p4ff23d6b.dip0.t-ipconnect.de. [79.242.61.107]) by smtp.gmail.com with ESMTPSA id 129sm4989801wmz.26.2021.08.25.03.38.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 03:38:32 -0700 (PDT) To: Catalin Marinas Cc: Robin Murphy , Mike Rapoport , Alex Bee , Will Deacon , Andrew Morton , Anshuman Khandual , Linux Kernel Mailing List , linux-mm@kvack.org, Linux ARM , Christoph Hellwig References: <20210824173741.GC623@arm.com> <0908ce39-7e30-91fa-68ef-11620f9596ae@arm.com> <60a11eba-2910-3b5f-ef96-97d4556c1596@redhat.com> <20210825102044.GA3420@arm.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases) Message-ID: Date: Wed, 25 Aug 2021 12:38:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210825102044.GA3420@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AZkF9MDP; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E926C90000B4 X-Stat-Signature: a6wcynwgq997onr3kgiydjx5dppbjrnt X-HE-Tag: 1629887915-898676 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.08.21 12:20, Catalin Marinas wrote: > + hch >=20 > On Tue, Aug 24, 2021 at 08:59:22PM +0200, David Hildenbrand wrote: >> On 24.08.21 20:46, Robin Murphy wrote: >>> On 2021-08-24 19:28, Mike Rapoport wrote: >>>> On Tue, Aug 24, 2021 at 06:37:41PM +0100, Catalin Marinas wrote: >>>>> On Tue, Aug 24, 2021 at 03:40:47PM +0200, Alex Bee wrote: >>>>>> it seems there is a regression in arm64 memory mapping in 5.14, si= nce it >>>>>> fails on Rockchip RK3328 when the pl330 dmac tries to map with: >>>>>> >>>>>> ------------[ cut here ]------------ >>>>>> WARNING: CPU: 2 PID: 373 at kernel/dma/mapping.c:235 dma_map_res= ource+0x68/0xc0 >>>>>> Modules linked in: spi_rockchip(+) fuse >>>>>> CPU: 2 PID: 373 Comm: systemd-udevd Not tainted 5.14.0-rc7 #1 >>>>>> Hardware name: Pine64 Rock64 (DT) >>>>>> pstate: 80000005 (Nzcv daif -PAN -UAO -TCO BTYPE=3D--) >>>>>> pc : dma_map_resource+0x68/0xc0 >>>>>> lr : pl330_prep_slave_fifo+0x78/0xd0 >>>>>> sp : ffff800012102ae0 >>>>>> x29: ffff800012102ae0 x28: ffff000005c94800 x27: 000000000000000= 0 >>>>>> x26: ffff000000566bd0 x25: 0000000000000001 x24: 000000000000000= 1 >>>>>> x23: 0000000000000002 x22: ffff000000628c00 x21: 000000000000000= 1 >>>>>> x20: ffff000000566bd0 x19: 0000000000000001 x18: 000000000000000= 0 >>>>>> x17: 0000000000000000 x16: 0000000000000000 x15: 000000000000000= 0 >>>>>> x14: 0000000000000277 x13: 0000000000000001 x12: 000000000000000= 0 >>>>>> x11: 0000000000000001 x10: 00000000000008e0 x9 : ffff800012102a8= 0 >>>>>> x8 : ffff000000d14b80 x7 : ffff0000fe7b12f0 x6 : ffff0000fe7b110= 0 >>>>>> x5 : fffffc000000000f x4 : 0000000000000000 x3 : 000000000000000= 1 >>>>>> x2 : 0000000000000001 x1 : 00000000ff190800 x0 : ffff000000628c0= 0 >>>>>> Call trace: >>>>>> dma_map_resource+0x68/0xc0 >>>>>> pl330_prep_slave_sg+0x58/0x220 >>>>>> rockchip_spi_prepare_dma+0xd8/0x2c0 [spi_rockchip] >>>>>> rockchip_spi_transfer_one+0x294/0x3d8 [spi_rockchip] >>>>> [...] >>>>>> Note: This does not relate to the spi driver - when disabling this= device in >>>>>> the device tree it fails for any other (i2s, for instance) which u= ses dma. >>>>>> Commenting out the failing check at [1], however, helps and the ma= pping >>>>>> works again. >>>> >>>>> Do you know which address dma_map_resource() is trying to map (mayb= e >>>>> add some printk())? It's not supposed to map RAM, hence the warning= . >>>>> Random guess, the address is 0xff190800 (based on the x1 above but = the >>>>> regs might as well be mangled). >>>> >>>> 0xff190800 will cause this warning for sure. It has a memory map, bu= t it is >>>> not RAM so old version of pfn_valid() would return 0 and the new one >>>> returns 1. >>> >>> How does that happen, though? It's not a memory address, and it's not >>> even within the bounds of anywhere there should or could be memory. T= his >>> SoC has a simple memory map - everything from 0 to 0xfeffffff goes to >>> the DRAM controller (which may not all be populated, and may have pie= ces >>> carved out by secure firmware), while 0xff000000-0xffffffff is MMIO. = Why >>> do we have pages (or at least the assumption of pages) for somewhere >>> which by all rights should not have them? >> >> Simple: we allocate the vmemmap for whole sections (e.g., 128 MiB) to = avoid >> any such hacks. If there is a memory hole, it gets a memmap as well. >> >> Tricking pfn_valid() into returning "false" where we actually have a m= emmap >> only makes it look like there is no memmap; but there is one, and >> it's PG_reserved. >=20 > I can see the documentation for pfn_valid() does not claim anything mor= e > than the presence of an memmap entry. But I wonder whether the confusio= n > is wider-spread than just the DMA code. At a quick grep, try_ram_remap(= ) > assumes __va() can be used on pfn_valid(), though I suspect it relies o= n > the calling function to check that the resource was RAM. The arm64 > kern_addr_valid() returns true based on pfn_valid() and kcore.c uses > standard memcpy on it, which wouldn't work for I/O (should we change > this check to pfn_is_map_memory() for arm64?). >=20 kern_addr_valid() checks that there is a direct map entry, and that the=20 mapped address has a valid mmap. (copied from x86-64) Would you expect to have a direct map for memory holes and similar (IOW,=20 !System RAM)? >>>>> Either pfn_valid() gets confused in 5.14 or something is wrong with= the >>>>> DT. I have a suspicion it's the former since reverting the above co= mmit >>>>> makes it disappear. >>>> >>>> I think pfn_valid() actually behaves as expected but the caller is w= rong >>>> because pfn_valid !=3D RAM (this applies btw to !arm64 as well). >>>> >>>> /* Don't allow RAM to be mapped */ >>>> if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) >>>> return DMA_MAPPING_ERROR; >>>> >>>> Alex, can you please try this patch: >>> >>> That will certainly paper over the issue, but it's avoiding the quest= ion >>> of what went wrong with the memory map in the first place. The commen= t >>> is indeed a bit inaccurate, but ultimately dma_map_resource() exists = for >>> addresses that would be wrong to pass to dma_map_page(), so I believe >>> pfn_valid() is still the correct check. >> >> If we want to check for RAM, pfn_valid() would be wrong. If we want to= check >> for "is there a memmap, for whatever lives or does not live there", >> pfn_valid() is the right check. >=20 > So what should the DMA code use instead? Last time we needed something > similar, the recommendation was to use pfn_to_online_page(). Mike is > suggesting memblock_is_memory(). We use pfn_to_online_page() when we want to know if it's system RAM and=20 that the memmap actually contains something sane (-> memmap content has=20 a well defined state). You can have offline memory blocks where pfn_to_online_page() would=20 return "false", memblock_is_memory() would return "true". IOW, there is=20 a memmap, it's System RAM, but the memmap is stale and not trustworthy. If you want to make sure no System RAM (online/offline/...) will get=20 mapped, memblock_is_memory() should be the right thing to use. I recall=20 that x86 traverse the resource tree instead to exclude system ram=20 regions similarly. >=20 > Given how later we are in the -rc cycle, I suggest we revert Anshuman's > commit 16c9afc77660 ("arm64/mm: drop HAVE_ARCH_PFN_VALID") and try to > assess the implications in 5.15 (the patch doesn't seem to have the > arm64 maintainers' ack anyway ;)). --=20 Thanks, David / dhildenb