Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=richard.marian.thomaiyar@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49bMFd1yrXzDqQB for ; Tue, 2 Jun 2020 03:13:24 +1000 (AEST) IronPort-SDR: ZgMKeaaNAk3/0EobNriZJdmzh+rqdj0gtoVzRRl4X/ywc0yAt2Tj/+p0L+SNUVTIMy1QFWneZb EafdlYR9nWyw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2020 10:13:20 -0700 IronPort-SDR: JYi3wUBhK2QAzLDStjE8Smy0XaRqwuDcXMMTW34yTzGHwS/aSqopIzAdzQfKPJV0wLRKVXyUNS /lstH77aEYtg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,461,1583222400"; d="scan'208,217";a="293259681" Received: from rthomaiy-mobl2.gar.corp.intel.com (HELO [10.251.55.164]) ([10.251.55.164]) by fmsmga004.fm.intel.com with ESMTP; 01 Jun 2020 10:13:15 -0700 To: Andrew Jeffery , Jeremy Kerr , "sumanth.bhat@linux.intel.com" , "Hawrylewicz Czarnowski, Przemyslaw" , OpenBMC Maillist From: "Thomaiyar, Richard Marian" Subject: MCTP Null EID - Physical addressing support - Binding private in API Message-ID: Date: Mon, 1 Jun 2020 22:43:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="------------44602D94E9C573E00C71B28D" Content-Language: en-US X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 17:13:26 -0000 This is a multi-part message in MIME format. --------------44602D94E9C573E00C71B28D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit All,  MCTP specification doesn’t restrict communication without EID assignment. i.e. MCTP devices can communicate with each other, even without EID’s (Spec limits bridging MCTP commands only – Sec 8.2 Special Endpoints in DSP0236). The scenario can happen in following cases 1. MCTP Bus owner available only in Main power and not on stand-by. In this case, devices are required to communicate using NULL EID, till main power is applied. 2. Till the EID’s are assigned by the Bus Owner, devices can communicate with NULL EID(Source & Dest). Even Bus owner, when it sends out SetEID or query GetEID, it must send with NULL EID (for Dest – Sec 12.3 Set Endpoint ID, 8.17.6 – Reclaiming EID’s from hot-plug devices in DSP0236) Similarly, as EndPoint device, need physical address of the bus owner, so that when SetEID is received from secondary/backup bus owner, we will know what to do? (Note: Secondary / backup bus owner may send with same bus owner EID, but it’s physical address will be different, and device can request for force Set EID). 3. Devices without bus owner in the network trying to communicate in peer-to-peer – single / simple network. There are also scenario’s where device’s issue Get EID command to the Bus owner to do a discovery or initiate discovery based on the need. In this case, there can be 2 / 3 devices which will issue this GetEID, and physical addressing is the way to differentiate the same.  This requires to pass physical addressing information to the MCTP Control command layer or to the upper layer from libmctp. Right now, all this information is dropped as part of binding to MCTP Assembly / disassembly before mctp_bus_rx. Hence, we need to have binding specific private structure in the mctp_pktbuff, which needs to tracked even along with MCTP Message buffer, apart from Source EID. Please comment / put your thoughts on the same. Regards, Richard --------------44602D94E9C573E00C71B28D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

All,

 MCTP specification doesn’t restrict communication without EID assignment. i.e. MCTP devices can communicate with each other, even without EID’s (Spec limits bridging MCTP commands only – Sec 8.2 Special Endpoints in DSP0236). The scenario can happen in following cases

1. MCTP Bus owner available only in Main power and not on stand-by. In this case, devices are required to communicate using NULL EID, till main power is applied.

2. Till the EID’s are assigned by the Bus Owner, devices can communicate with NULL EID(Source & Dest). Even Bus owner, when it sends out SetEID or query GetEID, it must send with NULL EID (for Dest – Sec 12.3 Set Endpoint ID, 8.17.6 – Reclaiming EID’s from hot-plug devices in DSP0236)

Similarly, as EndPoint device, need physical address of the bus owner, so that when SetEID is received from secondary/backup bus owner, we will know what to do? (Note: Secondary / backup bus owner may send with same bus owner EID, but it’s physical address will be different, and device can request for force Set EID).

3. Devices without bus owner in the network trying to communicate in peer-to-peer – single / simple network.

There are also scenario’s where device’s issue Get EID command to the Bus owner to do a discovery or initiate discovery based on the need. In this case, there can be 2 / 3 devices which will issue this GetEID, and physical addressing is the way to differentiate the same.

 This requires to pass physical addressing information to the MCTP Control command layer or to the upper layer from libmctp. Right now, all this information is dropped as part of binding to MCTP Assembly / disassembly before mctp_bus_rx. Hence, we need to have binding specific private structure in the mctp_pktbuff, which needs to tracked even along with MCTP Message buffer, apart from Source EID. Please comment / put your thoughts on the same.

 

Regards,

Richard

--------------44602D94E9C573E00C71B28D--