Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52FBDC433EF for ; Fri, 28 Jan 2022 17:37:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E2ADA8210D; Fri, 28 Jan 2022 18:37:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1643391452; bh=yzwqlp9OP4OEY2PWuTTpaIWnnr+HGGVDb5RMnomQdiw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XZYRe5lPryDUamqIUQSZ2lJqDpMehX+4xRDbjnu5dcQPCSF/dWK58BKgJQMjn0y0g vMeYeTuldXM0H3hge0dYqI2UCEYvss/3VBj/L6B9g7gi16/leXjYGU8qNsW07pVXK4 bs81tfbeEG1FqB5pxtYo+ioSqS/L/pHiQIvsxojyLXylCp5H9BJEWQtVYgLnUsWoWu 2Ouicf0bj2EZKisHfwwExMGQdtNByoc7ZDF9exd54aTC0A15X9DmsEl9gmuUiZ7V9i jY5RcuQhk6J8Kvie7dVkwfX/Sl443KxqeCQS/fR0814OIc6qYz9+NHL9xsZkvk95t9 a2euo89QIDdVQ== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id AA55381277; Fri, 28 Jan 2022 18:37:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1643391451; bh=yzwqlp9OP4OEY2PWuTTpaIWnnr+HGGVDb5RMnomQdiw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iwFSCWxwSxcJZac66wa2vq9yddmBdNga1QKh823UR+L6eQEGd9pZDJ+k9sN2bzTMl +GTlESrNbs2PvpV5VWoYCYW+mnZxsvbxeUoc6P+bDwxD8PcQ2cO6ASGbYqm1B2F5IH na11KkLlGfzmCnKW5GZypL6T8Pds1b5NmO28MVAgoJt6+dicac6W9nCPZLbziufVSd 1H3kgHbXUK6OOFnUhZdHBsKj8iqF9lFogRpVYhI5mpJRW049GaxFw2tCHjvJHFyc9/ /eWnN8d7OReqlo+3MIgR5C6TLeRWh/FkniC/TeEYcs2aBFw2Jbbs5gCIZHxS0XRuJ1 juW1X8beZz6yg== Message-ID: Date: Fri, 28 Jan 2022 18:37:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Revert "mmc: fsl_esdhc_imx: add wait_dat0() support" Content-Language: en-US To: Jaehoon Chung , u-boot@lists.denx.de Cc: sbabic@denx.de, Haibo Chen , Igor Opaniuk , Peng Fan References: <20220128034006.1410704-1-marex@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/28/22 08:30, Jaehoon Chung wrote: > Hi Marek, Hi, > On 1/28/22 12:40, Marek Vasut wrote: >> This reverts commit b5874b552ffa09bc1dc5dec6b5dd376c62dab45d. >> >> It seems the iMX8MM SDHC controller always reports DAT0 line status >> as zero after voltage switch at the end of mmc_switch_voltage(), even >> if it is supposed to be high and scope confirms the DAT0 is high. >> Reverting this patch makes SDR104 work on iMX8MM, however, it is >> not clear why the DAT0 status is not correctly reported by the >> controller. > > I didn't have an imx8mm board, so I wonder that other boards which is using fsl_esdhci_imx driver have same problem. I have multiple 8mm, just not the 8mm-evk. > I'm not sure...I remember that some controller doesn't support a busy signal. > In kernel driver, also doesn't report correct status? Kernel doesn't use this DAT0 readback, that's why it works in kernel. U-Boot has been augmented with this DAT0 readback some time ago, I just noticed it on an 8mm board recently that it doesn't really work. There is also no errata. I think it would be good to have NXP check this.