Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89E7C433DB for ; Tue, 22 Dec 2020 13:45:43 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89A0E23103 for ; Tue, 22 Dec 2020 13:45:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89A0E23103 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.57860.101426 (Exim 4.92) (envelope-from ) id 1krhyk-0003aC-2Q; Tue, 22 Dec 2020 13:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 57860.101426; Tue, 22 Dec 2020 13:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1krhyj-0003a5-VT; Tue, 22 Dec 2020 13:45:29 +0000 Received: by outflank-mailman (input) for mailman id 57860; Tue, 22 Dec 2020 13:45:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1krhyj-0003a0-Ct for xen-devel@lists.xenproject.org; Tue, 22 Dec 2020 13:45:29 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7b155724-1d3a-454f-bad1-4dfe5ef6c525; Tue, 22 Dec 2020 13:45:28 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 48CEFB1C2; Tue, 22 Dec 2020 13:45:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b155724-1d3a-454f-bad1-4dfe5ef6c525 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1608644727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7piISWuDwlyJQQ+sseEC12064PAEKVH/Rn56hAAVO5E=; b=ELPRDMQG1gxEYOsZHplyJcirxNivha0NLVgk37hpd5izhxEmN7VhEtMwjm/dLUfR0iVm8e LWEgZ9KF9AbIiBtfMHnEZUQ9kOAXHP0/sRQ1cqE48F9i8N3+o0LZkIA9vIFJhypz5+KDSv rKMBlj/7S0ZSYfRE7QnXoywgH/EvtMQ= Subject: Re: [PATCH 3/3] xen/evtchn: Clean up teardown handling To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Xen-devel References: <20201221181446.7791-1-andrew.cooper3@citrix.com> <20201221181446.7791-4-andrew.cooper3@citrix.com> <3d72bcb6-dabf-2b26-cecd-5f2d36505bd5@suse.com> <683f7808-aad7-1c42-e9e9-3e251e1a4561@citrix.com> <5d66a8c9-e3d6-e329-7daf-6b1d0e220e13@suse.com> <91ec88c5-fa7b-e700-2466-322dd3db7397@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 22 Dec 2020 14:45:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <91ec88c5-fa7b-e700-2466-322dd3db7397@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 22.12.2020 14:33, Andrew Cooper wrote: > On 22/12/2020 11:52, Jan Beulich wrote: >> On 22.12.2020 12:28, Andrew Cooper wrote: >>> On 22/12/2020 10:48, Jan Beulich wrote: >>>> On 21.12.2020 19:14, Andrew Cooper wrote: >>>>> First of all, rename the evtchn APIs: >>>>> * evtchn_destroy => evtchn_teardown >>>>> * evtchn_destroy_final => evtchn_destroy >>>> I wonder in how far this is going to cause confusion with backports >>>> down the road. May I suggest to do only the first of the two renames, >>>> at least until in a couple of year's time? Or make the second rename >>>> to e.g. evtchn_cleanup() or evtchn_deinit()? >>> I considered backports, but I don't think it will be an issue.  The >>> contents of the two functions are very different, and we're not likely >>> to be moving the callers in backports. >> Does the same also apply to the old and new call sites of the functions? > > I don't understand your question.  I don't intend the new callsites to > ever move again, now they're part of the properly idempotent path, and > any movement in the older trees would be wrong for anything other than > backporting this fix, which clearly isn't a backport candidate. > > (That said - there's a memory leak I need to create a backport for...) My thinking was that call sites of functions also serve as references or anchors when you do backports. Having identically named functions with different purposes may be misleading people - both ones doing backports on a very occasional basis, but also us who may be doing this regularly, but only on halfway recent trees. I, for one, keep forgetting to check for bool/true/false when moving to 4.7, or the -ERESTART <=> -EAGAIN change after 4.4(?). For the former I'll be saved by the compiler yelling at me, but for the latter one needs to recognize the need for an adjustment. I'm afraid of the same thing (granted at a lower probability) potentially happening here, down the road. Jan