From: "cron2 (Code Review)" Date: Wed, 5 Jun 2024 11:16:56 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="CPGoVoEclmo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --CPGoVoEclmo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/641?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: test_user_pass: Fix building with --enable-systemd ...................................................................... test_user_pass: Fix building with --enable-systemd Need to make sure that ENABLE_SYSTEMD is really disabled. Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20240605111012.3023-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28= 708.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/41/641/2 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index ac84654..b43e655 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -27,6 +27,8 @@ #endif #undef ENABLE_SYSTEMD +/* avoid redefining ENABLE_SYSTEMD in misc.c */ +#undef HAVE_CONFIG_H #include "syshead.h" #include "manage.h" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/641?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Gerrit-Change-Number: 641 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --CPGoVoEclmo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outda= ted and were removed: Code-Review+2 by cron2

test_user_pass: Fix building with --enable-systemd
Need to make sure that ENABLE_SYSTEMD is really disabled.

Chan= ge-Id: Ic33c210f06e173a450534aa0969c57f140086655
Signed-off-by: Frank Li= chtenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1711...= 96...>
Message-Id: <20240605111012.3023-1-gert@...1296...>
U= RL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg287= 08.html
Signed-off-by: Gert Doering <gert@...1296...>
---
M = tests/unit_tests/openvpn/test_user_pass.c
1 file changed, 2 insertions(+= ), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn=
 refs/changes/41/641/2
diff --git a/tests/unit_tests/openvpn/test_u=
ser_pass.c b/tests/unit_tests/openvpn/test_user_pass.c
inde= x ac84654..b43e655 100644
--- a/tests/unit_tests/openvpn/te= st_user_pass.c
+++ b/tests/unit_tests/openvpn/test_user_pas= s.c
@@ -27,6 +27,8 @@
#endif

#undef ENABLE_SYSTEMD
+/* avoid redefining ENABLE_SYSTEMD in misc.c */

+#undef HAVE_CONFIG_H

#include "syshead.h"
<= span> #include "manage.h"


To = view, visit change 641. To unsubscribe, or for help writing mail filters, visit = settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic33c210f06e173a450534aa0969= c57f140086655
Gerrit-Change-Number: 641
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--CPGoVoEclmo=--