Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1DDAC433EF for ; Wed, 18 May 2022 15:52:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CBA5284299; Wed, 18 May 2022 17:52:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Lcw9B5GN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 602058429A; Wed, 18 May 2022 17:52:41 +0200 (CEST) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6FD2684294 for ; Wed, 18 May 2022 17:52:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ej1-x62e.google.com with SMTP id ch13so4610027ejb.12 for ; Wed, 18 May 2022 08:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=SSzmx8Aasl3RhGW+GJEyPUc2ywGFHLj2Qa6Uf66iVUs=; b=Lcw9B5GNVyfbzFR4gU9+NVpn0jdz9f4GcIZDwKzkicDsY1BjFoFOn2jwoNs11z/zqs vEPKZhhc1NCCo1Sd44Uw5PnBJWvuDKIX9hUB5XhXnUhfUxe9oWHtOEwx3rUI6xy97SU9 sEFvJh3KHhn1sQag4firFrjIBOd9oOSKMTSkyKPLqcdlKDtNAci5+Y3McL28WqypDK7z rEZ1MnNbJpuZzvqU4GeanqtaAxsQB4d7z3kv7+VvdZdHYfuTaaApmXwtMCpKDNNUDC+F nDKZIb9sYyy8iWt5KoImCyg1y9fiXmhYVyFnmqKsd06HJ9SYI7QHq7QmeCCOL+7/SpnQ BWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SSzmx8Aasl3RhGW+GJEyPUc2ywGFHLj2Qa6Uf66iVUs=; b=36nbhLp5AUrpRFrsml6sgN05kJ91TDzM2CkbIbSu5xXjo9cR17hPz5kE2JzOQVESI2 vXkt3/hveW0bGILDMH0ikDCrnxAhP6ZqC7ljThNflRctpPWJF9DNvYfH4oyRyLMhpHmF gLyb79NIFux8hiB5HjrcsNP/jwaSj2QPONQo/g+7/r5428+E/iQyd6Z2ShFshk8MtB8Q u+3S273t0tdDxIsl0yHUzPdFOaLR2T/sRS3DYy06Mrfx8RtwyztRcGlmU8OnNYfoWGlV GQ4AR6yq2xd0xISGue/YoCGm4XX9PII0R64Ac55yxtCYS5+aF0BnBtEgGaZLurucwP8w 3Ysw== X-Gm-Message-State: AOAM530PVeWsgcQHZAK8i8/8UdYL2RnZhBNN8sQF9Qb+OCFsGx3L7xzS 3aS4K4VKnvAj0V2q44SB8DLhrqIb2gk= X-Google-Smtp-Source: ABdhPJzm8D+kM4WNf/oz2EWFlMm/sFriXJS1G7Byv9LG6QLv9VWsCrMHp9ogJqF9LTxsLjFAjGjBMA== X-Received: by 2002:a17:906:3ec1:b0:6e8:aae3:90de with SMTP id d1-20020a1709063ec100b006e8aae390demr219673ejj.127.1652889158069; Wed, 18 May 2022 08:52:38 -0700 (PDT) Received: from [192.168.10.30] (i5E8607DC.versanet.de. [94.134.7.220]) by smtp.gmail.com with ESMTPSA id v2-20020a17090651c200b006f3ef214e20sm1113932ejk.134.2022.05.18.08.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 08:52:37 -0700 (PDT) Message-ID: Date: Wed, 18 May 2022 17:52:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Kconfig: hide options not intended for users in arch/Kconfig Content-Language: en-US To: Tom Rini Cc: u-boot@lists.denx.de, Priyanka Jain References: <20220517205353.2653667-1-daniel.schwierzeck@gmail.com> <20220518121849.GV3901321@bill-the-cat> <20220518152207.GB3901321@bill-the-cat> From: Daniel Schwierzeck In-Reply-To: <20220518152207.GB3901321@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 18.05.22 17:22, Tom Rini wrote: > On Wed, May 18, 2022 at 05:12:13PM +0200, Daniel Schwierzeck wrote: >> >> >> On 18.05.22 14:18, Tom Rini wrote: >>> On Tue, May 17, 2022 at 10:53:53PM +0200, Daniel Schwierzeck wrote: >>>> Those options show up in menuconfig when selecting ARM or MIPS which >>>> is dangerous if a user accidently sets them. This also clutters up the >>>> menuconfig top-level screen. Because those options should only be set >>>> by SoC specific or board specific configs, make them invisible. >>>> >>>> Signed-off-by: Daniel Schwierzeck >>>> >>>> --- >>>> >>>> arch/Kconfig | 14 +++++++------- >>>> 1 file changed, 7 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/arch/Kconfig b/arch/Kconfig >>>> index 12de8a1165..e3e28d0628 100644 >>>> --- a/arch/Kconfig >>>> +++ b/arch/Kconfig >>>> @@ -365,7 +365,7 @@ config SYS_DISABLE_DCACHE_OPS >>>> this functionality. >>>> config SYS_IMMR >>>> - hex "Address for the Internal Memory-Mapped Registers (IMMR) window" >>>> + hex >>>> depends on PPC || FSL_LSCH2 || FSL_LSCH3 || ARCH_LS1021A >>>> default 0xFF000000 if MPC8xx >>>> default 0xF0000000 if ARCH_MPC8313 >>> >>> But now these aren't user selectable on the right platforms either. >>> Maybe we need more menu organization, and so can have sub-menus depend >>> on PPC, or whatever, and so things aren't cluttered on other >>> architectures? >>> >> >> my main concern was with SKIP_LOWLEVEL_INIT which definitely should not be >> selectable by the user. Maybe I was to overambitious with changing the >> SYS_IMMR option too, I could revert that part ;) > > I'd be agreeable to a patch that makes everyone that enables it today > select it instead. I'll look into it. Would moving this to top-level Kconfig and the "General setup" menu be an option? > >> BTW: SYS_IMMR seems to be specific for PPC. Maybe it could be moved to >> arch/powerpc/Kconfig? > > It's PowerPC or the 64bit ARM Layerscape platforms. There's I think > only several imperfect places today for the options that are present in > both due to the IP blocks / etc being updated by NXP for use in their > current ARM HW. > -- - Daniel