Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10CDE442A for ; Tue, 4 Oct 2022 21:12:17 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id s30so16815224eds.1 for ; Tue, 04 Oct 2022 14:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ek0YcmYCHx5SGFTNcMBDbhOgrCmQLd482qHy+VkjZ7c=; b=DmH6gGKzxeEi1nDjvicR7wZqCweWulq1P/JZZ1CapyIkUYXRemmo91ltJZXJtR2Jdw jmOo5NEitzjpFMZMMER4j+dHI/0lh3ySkX8v3Bmieij/pv87iVamWRXLhTvpMPvmAHxU JMqRxV+rUURi+VFLE5FfjlamHJWnE7ry6lom2TqHezeADm5Dl81/t3nr1xnchPGhNt1h cnZCxOHtwveH/fjsxprsiOzlqN3kNbaXm1OXOt4Ij390UDSVgFKX33QZSWiQhIZ2WMy0 WnZqFWdzZqX9ReU+aGuKhdDBFjSUNhyuAeZZd4V2YDvStFd8hHtqQfs1lqa4tonwkwNY 48bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ek0YcmYCHx5SGFTNcMBDbhOgrCmQLd482qHy+VkjZ7c=; b=WawZcrV+vDo5/z1ta/VFNcTOY7h03i1RRryVVRbxVJZDkalm4XxCy7KsFrzh5/vxUB EBMu/9Y2NhqZTi9NvaM2B038IIqEll+sEdfM6NmVC5spbMSSOL+asU/hQ7dfLvSpvMn4 yd26qGjxjN9OR1tQgvjFDiEESQWv22fUJbU3lJx3xNubckOQi2zx70bPdCjMYNMR20RX Arr7M3CydsKWXpFlPZxhtcCW2MzON/sBXvwnzY3HrzwSOGfUn0YGEX9dCLJKjij8K3oQ /2OdSFDfnn89Rs0g0aHAo0nV6Dhtum17UUfuPZAkQO5aAQGcsaLVarUge75wjBss+HBd uFlQ== X-Gm-Message-State: ACrzQf1QqF3R1CnN542DLS30+JxNkwM0L/XQA0uV63ANfuDE58qsCCyD NPhzMOQZ7XvFti4eRcGLqVw= X-Google-Smtp-Source: AMsMyM5iGOsddvtBCJeMBPxs7ofxnSK5HXPdj2k2Qo9gJwsmlRzWcbn3jgiaKX7GsmuFtTo6tohPwA== X-Received: by 2002:a05:6402:414f:b0:456:c2c1:23ec with SMTP id x15-20020a056402414f00b00456c2c123ecmr26233787eda.420.1664917936245; Tue, 04 Oct 2022 14:12:16 -0700 (PDT) Received: from ?IPV6:2003:c7:8f3e:6a06:125d:3a8d:82a2:428d? (p200300c78f3e6a06125d3a8d82a2428d.dip0.t-ipconnect.de. [2003:c7:8f3e:6a06:125d:3a8d:82a2:428d]) by smtp.gmail.com with ESMTPSA id sh39-20020a1709076ea700b00734bfab4d59sm427380ejc.170.2022.10.04.14.12.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 14:12:15 -0700 (PDT) Message-ID: Date: Tue, 4 Oct 2022 23:12:15 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] staging: rtl8723bs: Remove redundant initialization of variable efuseValue Content-Language: en-US To: Colin Ian King , Greg Kroah-Hartman , Saurav Girepunje , linux-staging@lists.linux.dev Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221004153539.150867-1-colin.i.king@gmail.com> From: Philipp Hortmann In-Reply-To: <20221004153539.150867-1-colin.i.king@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/4/22 17:35, Colin Ian King wrote: > The variable efuseValue is being initialized with a value that is never > read. The variable is being re-assigned later on. The initialization is > redundant and can be removed. > > Cleans up warning: > drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable > 'efuseValue' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c > index 06e727ce9cc2..eb848f9bbf2c 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c > @@ -282,7 +282,7 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoT > { > u8 tmpidx = 0; > u8 bResult = false; > - u32 efuseValue = 0; > + u32 efuseValue; > > if (bPseudoTest) > return Efuse_Write1ByteToFakeContent(addr, data); I propose to remove all lines with efuseValue as it is dead code. Make a v2 of this patch with version history below the --- Thanks for your support. Bye Philipp