Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53259CA0ED3 for ; Mon, 2 Sep 2024 10:17:07 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.787774.1197232 (Exim 4.92) (envelope-from ) id 1sl47F-0004T9-V5; Mon, 02 Sep 2024 10:16:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 787774.1197232; Mon, 02 Sep 2024 10:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sl47F-0004T2-Rk; Mon, 02 Sep 2024 10:16:57 +0000 Received: by outflank-mailman (input) for mailman id 787774; Mon, 02 Sep 2024 10:16:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sl47E-0004Sw-AC for xen-devel@lists.xenproject.org; Mon, 02 Sep 2024 10:16:56 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a41a004-6914-11ef-99a1-01e77a169b0f; Mon, 02 Sep 2024 12:16:54 +0200 (CEST) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5334879ba28so5655502e87.3 for ; Mon, 02 Sep 2024 03:16:54 -0700 (PDT) Received: from [10.125.226.166] ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891966dasm538435266b.122.2024.09.02.03.16.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 03:16:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a41a004-6914-11ef-99a1-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1725272214; x=1725877014; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=lOKKXuD34ef7ftgSEV6LC3IL4NJW4RQq/K220rT7kU8=; b=K88Z7fyDxa9pJ6uPaawD+ZPgtsQjq6OFRWDJH3MMEedjXbhFtIWWt8ggsiqiWvxaRg QrqmF3UQMYJugMHxOc5CaO90j1Z+xHmNPBHgk0BYEUJPfRcyb7uNcZvHuLGWGR0n9Opi kbYCryEBYP9ko75l3/quhLmuFV1Pgq18Dbvkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725272214; x=1725877014; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lOKKXuD34ef7ftgSEV6LC3IL4NJW4RQq/K220rT7kU8=; b=NZACKhpPZgogBpbK/J9e51K6ezuBmcnJ6ddAs4Eb5Abi4rJUs052g/MXQykx7/FviT RTBhzgLywVMow4lJMF/bf7oAhua43E8FIVh5Rn98QxGKL96C2HXXu1gcFUMv/jNPH2zs 1sl6xJzrIEYAJSYlpPPfkpF9H29EFS3X2O6Zsi5uqDvj0hNuZxuJOW+gFVT9kHi9Ufzy jANzL+CyjXxycYcKZ5qIqmkOGZ8/9UYk8GCIrV05A08v2tqZO3F+TXjPo0HWJGE8W22b hGmuFQu3FXe9Iq7F8J8Ndwe/zipmUSGrnOlLopn7qHj1+1sHFJw14SHQqOFPgBIKwEaV z/1g== X-Gm-Message-State: AOJu0YzshMyFolPPSfAMwTvOkSU4yebwOhk5Z/TazqvyHZS9rgIy8CmE p/FVba3g7KqjaCdjVY7e4p+5R/HwHTZTWXVw77cSx4Ge2WgxmeT65URh8JRJ5H4= X-Google-Smtp-Source: AGHT+IHCLp0FslecNOAvDQFJPGwVhbBGtXfw/Werl3830Ew3vhKHUgP/GCWLbAtWiCOghNS6jM4O4A== X-Received: by 2002:a05:6512:3d28:b0:52c:e670:7a12 with SMTP id 2adb3069b0e04-53546bc2c75mr5912871e87.60.1725272213244; Mon, 02 Sep 2024 03:16:53 -0700 (PDT) Message-ID: Date: Mon, 2 Sep 2024 11:16:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/boot: Use C99 types for integers To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <20240829115247.168608-1-frediano.ziglio@cloud.com> <594b5ad4-0b86-4397-a261-0e98515e3abe@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 29/08/2024 2:42 pm, Frediano Ziglio wrote: > On Thu, Aug 29, 2024 at 1:07 PM Andrew Cooper wrote: >> On 29/08/2024 12:52 pm, Frediano Ziglio wrote: >>> diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h >>> index 239b9f8716..ee1a4da6af 100644 >>> --- a/xen/arch/x86/boot/defs.h >>> +++ b/xen/arch/x86/boot/defs.h >>> @@ -57,7 +57,7 @@ typedef u16 uint16_t; >>> typedef u32 uint32_t; >>> typedef u64 uint64_t; >>> >>> -#define U16_MAX ((u16)(~0U)) >>> +#define UINT16_MAX ((uint16_t)(~0U)) >>> #define UINT_MAX (~0U) >>> >>> #endif /* __BOOT_DEFS_H__ */ >> I'm happy with the change in principle, but could we see about dropping >> defs.h entirely? For example, we've already got both of these UINT >> constants in types.h >> >> Since this was written, we've got rather better about cleaning up >> xen/types.h, and extracting macros into xen/macros.h >> >> I think there's a good chance that the regular headers can now be used >> directly, or with minor tweaking. >> > I tried, it gave a huge bunch of errors. > I think it can be done in a later follow-up. Ok fine. Acked-by: Andrew Cooper However, doesn't this mean we can drop the block of typedefs in the context above?  Happy to fold that in on commit. ~Andrew