From: Josef Bacik Subject: Re: remove revalidate_disk() Date: Tue, 1 Sep 2020 13:45:58 -0400 Message-ID: References: <20200901155748.2884-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200901155748.2884-1-hch@lst.de> Content-Language: en-US Sender: ceph-devel-owner@vger.kernel.org To: Christoph Hellwig , Jens Axboe Cc: Dan Williams , dm-devel@redhat.com, "Martin K. Petersen" , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org List-Id: dm-devel.ids On 9/1/20 11:57 AM, Christoph Hellwig wrote: > Hi Jens, > > this series removes the revalidate_disk() function, which has been a > really odd duck in the last years. The prime reason why most people > use it is because it propagates a size change from the gendisk to > the block_device structure. But it also calls into the rather ill > defined ->revalidate_disk method which is rather useless for the > callers. So this adds a new helper to just propagate the size, and > cleans up all kinds of mess around this area. Follow on patches > will eventuall kill of ->revalidate_disk entirely, but ther are a lot > more patches needed for that. > I applied and built everything on Jens's for-next, patch #2 was fuzzy but it applied. I checked through everything, the only thing that was strange to me is not calling revalidate_disk_size() in nvdimm, but since it's during attach you point out it doesn't matter. You can add Reviewed-by: Josef Bacik To the series, thanks, Josef