From: "Zhang, Jerry(Junwei)" Subject: Re: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants Date: Mon, 26 Nov 2018 10:38:25 +0800 Message-ID: References: <20181123083227.25555-1-Jerry.Zhang@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1872357461==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Deucher, Alexander" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" --===============1872357461== Content-Type: multipart/alternative; boundary="------------EC7C7E96E410090788E666C7" Content-Language: en-US --------------EC7C7E96E410090788E666C7 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 11/24/18 3:32 AM, Deucher, Alexander wrote: > > Is this required?  Are the harvesting fuses incorrect?  If the blocks > are harvested, we should bail out of the blocks properly during init. >  Also, please make this more explicit if we still need it.  E.g., > > The harvest fuse is indeed disabling UVD and VCE, as it's a mining card. Then any command to UVD/VCE causing NULL pointer issue, like amdgpu_test. AFAIW, windows also disable UVD and VCE in initialization. >        if ((adev->pdev->device == 0x67df) && >               (adev->pdev->revision == 0xf7)) { > > /* Some polaris12 variants don't support UVD/VCE */ > >       } else  { > > amdgpu_device_ip_block_add(adev, &uvd_v6_3_ip_block); > > amdgpu_device_ip_block_add(adev, &vce_v3_4_ip_block); > >     } > > OK, will explicit the process. Regards, Jerry > > That way if we re-arrange the order later, it will be easier to track. > > > Alex > > ------------------------------------------------------------------------ > *From:* amd-gfx on behalf of > Junwei Zhang > *Sent:* Friday, November 23, 2018 3:32:27 AM > *To:* amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > *Cc:* Zhang, Jerry > *Subject:* [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 > variants > Some variants don't support UVD and VCE. > > Signed-off-by: Junwei Zhang > --- >  drivers/gpu/drm/amd/amdgpu/vi.c | 4 ++++ >  1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c > b/drivers/gpu/drm/amd/amdgpu/vi.c > index f3a4cf1f013a..3338b013ded4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1660,6 +1660,10 @@ int vi_set_ip_blocks(struct amdgpu_device *adev) >                          amdgpu_device_ip_block_add(adev, > &dce_v11_2_ip_block); >                  amdgpu_device_ip_block_add(adev, &gfx_v8_0_ip_block); >                  amdgpu_device_ip_block_add(adev, &sdma_v3_1_ip_block); > +               /* Some polaris12 variants don't support UVD/VCE */ > +               if ((adev->pdev->device == 0x67df) && > +                     (adev->pdev->revision == 0xf7)) > +                       break; >                  amdgpu_device_ip_block_add(adev, &uvd_v6_3_ip_block); >                  amdgpu_device_ip_block_add(adev, &vce_v3_4_ip_block); >                  break; > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx --------------EC7C7E96E410090788E666C7 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit On 11/24/18 3:32 AM, Deucher, Alexander wrote:

Is this required?  Are the harvesting fuses incorrect?  If the blocks are harvested, we should bail out of the blocks properly during init.  Also, please make this more explicit if we still need it.  E.g.,



The harvest fuse is indeed disabling UVD and VCE, as it's a mining card.
Then any command to UVD/VCE causing NULL pointer issue, like amdgpu_test.

AFAIW, windows also disable UVD and VCE in initialization.

       if ((adev->pdev->device == 0x67df) &&
              (adev->pdev->revision == 0xf7)) {

        /* Some polaris12 variants don't support UVD/VCE */

      } else  {

                 amdgpu_device_ip_block_add(adev, &uvd_v6_3_ip_block);

                 amdgpu_device_ip_block_add(adev, &vce_v3_4_ip_block);

    }



OK, will explicit the process.

Regards,
Jerry

That way if we re-arrange the order later, it will be easier to track.


Alex


From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
Sent: Friday, November 23, 2018 3:32:27 AM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Zhang, Jerry
Subject: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants
 
Some variants don't support UVD and VCE.

Signed-off-by: Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index f3a4cf1f013a..3338b013ded4 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -1660,6 +1660,10 @@ int vi_set_ip_blocks(struct amdgpu_device *adev)
                         amdgpu_device_ip_block_add(adev, &dce_v11_2_ip_block);
                 amdgpu_device_ip_block_add(adev, &gfx_v8_0_ip_block);
                 amdgpu_device_ip_block_add(adev, &sdma_v3_1_ip_block);
+               /* Some polaris12 variants don't support UVD/VCE */
+               if ((adev->pdev->device == 0x67df) &&
+                     (adev->pdev->revision == 0xf7))
+                       break;
                 amdgpu_device_ip_block_add(adev, &uvd_v6_3_ip_block);
                 amdgpu_device_ip_block_add(adev, &vce_v3_4_ip_block);
                 break;
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

--------------EC7C7E96E410090788E666C7-- --===============1872357461== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============1872357461==--