From: "selvanair (Code Review)"
Date: Wed, 19 Jun 2024 01:56:33 +0000
In-Reply-To:
References:
Reply-To: selva.nair@...277..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="pjjpspmWYz0="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Static-challenge
concatenation option
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--pjjpspmWYz0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/665?usp=3Demail )
Change subject: Static-challenge concatenation option
......................................................................
Patch Set 2:
(1 comment)
File doc/man-sections/client-options.rst:
http://gerrit.openvpn.net/c/openvpn/+/665/comment/46ddef1b_f7400222 :
PS1, Line 552: :code: `0` is the default.
> I am not a big fan of this option but I will not block it. [=E2=80=A6]
I share that sentiment, but some GUI users want something like this. It fee=
ls better to have this defined in the core than invent it in the GUI.
Changed 0/1 to scrv1/concat.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d
Gerrit-Change-Number: 665
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 19 Jun 2024 01:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos
Gerrit-MessageType: comment
--pjjpspmWYz0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View C=
hange
1 comment:
I share that sentiment, but some GUI use=
rs want something like this. It feels better to have this defined in the co=
re than invent it in the GUI.
Changed 0/1 to scrv1/concat.
To =
view, visit change 665. To unsubscribe, or for help writing mail filters, visit =
settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I59a90446bfe73d8856516025a58=
a6f62cc98ab0d
Gerrit-Change-Number: 665
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...=
..>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Wed, 19 Jun 2024 01:56:33=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Gerrit-MessageType: comment
--pjjpspmWYz0=--