Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D92F8C433F5 for ; Wed, 6 Apr 2022 10:22:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 84E5D83110; Wed, 6 Apr 2022 12:22:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="veQHAqek"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4C80883110; Wed, 6 Apr 2022 12:22:08 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 83B3880084 for ; Wed, 6 Apr 2022 12:22:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 1A77622248; Wed, 6 Apr 2022 12:22:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1649240523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1gMrBtGMJGIRNP/s0jxxqqzqR/Lmo5R024Fz+YTIjR0=; b=veQHAqek6XVQ9Ue4txCf2MYnvaKZXykg7cq+iXTu/fl0nf0qS/NRD7KMDCwhem5pQcWcY1 LTBqMbAAtWPHN0DgHC44QEr5M6tUhG1cw51eovOALOZbEdNL6HfnW5brOCVvrV8Q2+R8mV UZBQu2pMkWwTgUzxBnNY6MP4kv38ypY= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 06 Apr 2022 12:22:02 +0200 From: Michael Walle To: u-boot@lists.denx.de, Tom Rini Subject: Re: [PATCH] armv8: sec_firmware: drop unneeded ARMV8_SEC_FIRMWARE_SUPPORT check In-Reply-To: <20211126161136.66006-1-michael@walle.cc> References: <20211126161136.66006-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Am 2021-11-26 17:11, schrieb Michael Walle: > This module will only be compiled if this symbol is set. Remove the > useless check. While at it, invert the return code, to return 0 if the > function succeeds. The only user of this function in > arch/arm/cpu/armv8/fsl-layerscape/fdt.c doesn't check the return code > anyway, so its safe change it. > > Signed-off-by: Michael Walle Ping? :) Tom, this is assigned to you in patchwork. -michael