Received: from eggs.gnu.org ([209.51.188.92]:58575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpIsH-0000Yc-Bu for qemu-devel@nongnu.org; Thu, 31 Jan 2019 15:23:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpIsF-0006jW-Qb for qemu-devel@nongnu.org; Thu, 31 Jan 2019 15:23:49 -0500 References: <20190117185628.21862-1-crosa@redhat.com> <20190117185628.21862-19-crosa@redhat.com> <9400afcf-7c67-fd69-0b0d-1f7449ffc35c@redhat.com> From: Cleber Rosa Message-ID: Date: Thu, 31 Jan 2019 15:23:31 -0500 MIME-Version: 1.0 In-Reply-To: <9400afcf-7c67-fd69-0b0d-1f7449ffc35c@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 18/18] Boot Linux Console Test: add a test for alpha + clipper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefan Markovic , Aleksandar Markovic , Eduardo Habkost , Caio Carrara , qemu-s390x@nongnu.org, Aurelien Jarno , Cornelia Huck , Fam Zheng , Wainer dos Santos Moschetta , Aleksandar Rikalo , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= On 1/31/19 5:30 AM, Philippe Mathieu-Daud=C3=A9 wrote: > On 1/31/19 3:53 AM, Cleber Rosa wrote: >> On 1/22/19 5:52 AM, Philippe Mathieu-Daud=C3=A9 wrote: >>> On 1/17/19 7:56 PM, Cleber Rosa wrote: >>>> Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta >>>> board and verify the serial is working. One extra command added to >>>> the QEMU command line is '-vga std', because the kernel used is >>>> known to crash without it. >>>> >>>> If alpha is a target being built, "make check-acceptance" will >>>> automatically include this test by the use of the "arch:alpha" tags. >>>> >>>> Alternatively, this test can be run using: >>>> >>>> $ avocado run -t arch:alpha tests/acceptance >>>> $ avocado run -t machine:clipper tests/acceptance >>>> >>>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>>> Signed-off-by: Cleber Rosa >>>> --- >>>> .travis.yml | 2 +- >>>> scripts/qemu.py | 1 - >>>> tests/acceptance/boot_linux_console.py | 22 ++++++++++++++++++++++ >>>> 3 files changed, 23 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/.travis.yml b/.travis.yml >>>> index 0d5a4b104b..73a113af87 100644 >>>> --- a/.travis.yml >>>> +++ b/.travis.yml >>>> @@ -187,7 +187,7 @@ matrix: >>>> =20 >>>> # Acceptance (Functional) tests >>>> - env: >>>> - - CONFIG=3D"--python=3D/usr/bin/python3 --target-list=3Dx86= _64-softmmu,mips-softmmu,mips64el-softmmu,ppc64-softmmu,aarch64-softmmu,a= rm-softmmu,s390x-softmmu" >>>> + - CONFIG=3D"--python=3D/usr/bin/python3 --target-list=3Dx86= _64-softmmu,mips-softmmu,mips64el-softmmu,ppc64-softmmu,aarch64-softmmu,a= rm-softmmu,s390x-softmmu,alpha-softmmu" >>>> - TEST_CMD=3D"make check-acceptance" >>>> addons: >>>> apt: >>>> diff --git a/scripts/qemu.py b/scripts/qemu.py >>>> index 1531e28fc1..a704da418a 100644 >>>> --- a/scripts/qemu.py >>>> +++ b/scripts/qemu.py >>>> @@ -34,7 +34,6 @@ def kvm_available(target_arch=3DNone): >>>> =20 >>>> #: Maps machine types to the preferred console device types >>>> CONSOLE_DEV_TYPES =3D { >>>> - r'^clipper$': 'isa-serial', >>> >>> Why this change? >>> >> >> Because we've come to conclusion (I believe :) that's better, whenever >> possible, to let QEMU pick the default device type by machine. The >> discussion happened here: >> >> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg04582.html >=20 > I was expecting this change to be global (in a single patch previous to > the target-specific patches). If you prefer to do it a target at a time > I'm OK with it but you should add a comment about it in the commit IMHO= . >=20 > Regards, >=20 > Phil. >=20 You're right, that's a better approach. I've made this change part of the set_console() changes. Thanks! - Cleber.