Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2494C77B72 for ; Fri, 14 Apr 2023 21:43:28 +0000 (UTC) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by mx.groups.io with SMTP id smtpd.web10.454.1681508601856991991 for ; Fri, 14 Apr 2023 14:43:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ti.com header.s=ti-com-17q1 header.b=CMMK/DJh; spf=pass (domain: ti.com, ip: 198.47.19.142, mailfrom: afd@ti.com) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33ELhBoL058360; Fri, 14 Apr 2023 16:43:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681508591; bh=uzjVkvWpNvKFiDAMQYcQT3S3zs4GpxOWsKGOq/qHuTg=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=CMMK/DJhbRHzpyESbu3tKDHJSBthR5r6Qswf9FByZCzI3Cp8mnxp758qykmaDPczw xh3/rOIwUl6OrI4RxyW++ToGQzm46kxyYtxKJEVdf5gzfdvblg0s44NItXs4nj/9LZ F3DuVwiHEhTW9nRm7FmkoakdIcmqc8Tgw339DhgY= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33ELhBua017814 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Apr 2023 16:43:11 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 14 Apr 2023 16:43:11 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 14 Apr 2023 16:43:11 -0500 Received: from [10.250.32.8] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33ELhBcQ120412; Fri, 14 Apr 2023 16:43:11 -0500 Message-ID: Date: Fri, 14 Apr 2023 16:43:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [meta-ti][master/kirkstone][PATCH v2 5/6] meta-ti-bsp: Remove SGX driver from SIGGEN_EXCLUDERECIPES_ABISAFE Content-Language: en-US To: Denys Dmytriyenko CC: Denys Dmytriyenko , Ryan Eatmon , Randolph Sapp , References: <20230412184242.29743-1-afd@ti.com> <20230412184242.29743-5-afd@ti.com> <20230412204312.GJ9226@denix.org> <57e5d47d-3088-0df6-608b-35bb21f8c91f@ti.com> <20230412212519.GL9226@denix.org> <20230414205407.GO9226@denix.org> From: Andrew Davis In-Reply-To: <20230414205407.GO9226@denix.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 14 Apr 2023 21:43:28 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-ti/message/16403 On 4/14/23 3:54 PM, Denys Dmytriyenko wrote: > On Wed, Apr 12, 2023 at 04:28:45PM -0500, Andrew Davis wrote: >> On 4/12/23 4:25 PM, Denys Dmytriyenko wrote: >>> On Wed, Apr 12, 2023 at 04:08:50PM -0500, Andrew Davis wrote: >>>> On 4/12/23 3:43 PM, Denys Dmytriyenko wrote: >>>>> On Wed, Apr 12, 2023 at 01:42:41PM -0500, Andrew Davis via lists.yoctoproject.org wrote: >>>>>> Neither of recipes nor their ABI is all that stable. OpenGL might be >>>>>> slightly more stable, but that is not what these provide anymore. >>>>>> Remove these. >>>>> >>>>> This is not what you think it is... :) Actually, Rogue recipes should be added >>>>> to the list. >>>>> >>>>> This is specific to signatures/shared state. The ABI in this case is libgles >>>>> and libegl (which are stable) and tells bitbake to avoid rebuilding generic >>>>> apps depending on these packages between platfoms in the same architecture. >>>>> >>>> >>>> These do not provide those API anymore, Mesa does. And nothing should depend >>>> on the KM package other than the UM libs. >>> >>> Still doesn't matter - if you have Mesa depend on these, you still need them >>> listed in here to avoid rebuilding Mesa from one platform to another. And >>> everything else downstream. >>> >> >> We *want* Mesa to be rebuilt if these change, these do not provide a stable ABI >> anymore, it can and does change, sometimes between platforms (SGX KM -> UM is >> based on plat). > > The name of the variable may be confusing. It's not about rebuilding Mesa once > you make changes to the KM/UM pieces - that will happen automatically if the > dependencies are tracked properly. > > This variable is about re-use of the dependant generic packages. The issue it > is trying to solve is when you have machine-specific packages early in the > dependecy tree, everything down the dependency tree that depends on these > packages will be treated as machine-specific, even if they are generic. Since > bitbake will try to play safe here, you have to tell it otherwise. > > Again, this is not about rebuilds of a dependent component between changes. > This is about rebuilds of a dependent component between different machines > (platforms) w/o making any changes. > > For example, Wayland, Weston and all Qt5 modules are generic and should be > re-used from shared state across all our Aarch64 platforms, but that's not the > case and they are being rebuilt for each and every platform again and again. > > I've done some experiments locally - back when SGX/Rogue UM libs provided > libgles, libegl, libgbm (which API/ABI are supposed to be stable!), you > certainly wanted to have them listed in this SIGGEN_EXCLUDERECIPES_ABISAFE > list. Now, those ABIs have shifted to Mesa and we do mark that package as > machine-specific (I had to add PACKAGE_ARCH = "${MACHINE_ARCH}" when redoing > Reese's patches - see v8 changes section at [1]). With that in mind, this > variable now has to list Mesa instead of individual UM packages - the patch > is coming. > So then we are saying the same thing, the UM libs should not be listed here. This patch should go in then, and another one that adds Mesa to the list can go in after. If that is fine, then the first 5 patches in this series should be good to go. Andrew