Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBEFC43331 for ; Mon, 30 Mar 2020 10:54:51 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7418C20716 for ; Mon, 30 Mar 2020 10:54:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7418C20716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIs3p-0002yI-6R; Mon, 30 Mar 2020 10:54:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIs3o-0002yD-6k for xen-devel@lists.xenproject.org; Mon, 30 Mar 2020 10:54:28 +0000 X-Inumbo-ID: d3156d18-7274-11ea-9e09-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d3156d18-7274-11ea-9e09-bc764e2007e4; Mon, 30 Mar 2020 10:54:27 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 89666AF4F; Mon, 30 Mar 2020 10:54:26 +0000 (UTC) To: Paul Durrant References: <20200327185012.1795-1-paul@xen.org> <20200327185012.1795-4-paul@xen.org> From: Jan Beulich Message-ID: Date: Mon, 30 Mar 2020 12:54:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200327185012.1795-4-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Xen-devel] [PATCH 3/5] tools/misc: add xen-ctx to present domain context X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 27.03.2020 19:50, Paul Durrant wrote: > This tools is analogous to 'xen-hvmctx' which presents HVM context. > Subsequent patches will add 'dump' functions when new records are > introduced. > > Signed-off-by: Paul Durrant > --- > Cc: Ian Jackson > Cc: Wei Liu > --- > .gitignore | 1 + > tools/misc/Makefile | 4 ++ > tools/misc/xen-ctx.c | 144 +++++++++++++++++++++++++++++++++++++++++++ Is xen-ctx a good choice of a name, considering we already have not only xen-hvmctx, but also xenctx? If the new functionality isn't a good fit for either, perhaps its name would better reflect its connection to save/restore records? xen-sr-dump looks pretty clumsy to me, but still seems better than a name easily mixed up with others. Jan