From: Chris Wilson Subject: Re: [PATCH xf86-video 2/2] dri: fix leakage of FB when closing the screen Date: Wed, 05 Sep 2012 11:19:30 +0100 Message-ID: References: <1346412711-4257-1-git-send-email-imre.deak@intel.com> <1346412711-4257-2-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 01FFA9F774 for ; Wed, 5 Sep 2012 03:19:33 -0700 (PDT) In-Reply-To: <1346412711-4257-2-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 31 Aug 2012 14:31:51 +0300, Imre Deak wrote: > Calling drmModeRmFB is only allowed in DRM master mode. Since leaving > the VT also drops master mode we need to remove the FB before calling > I830LeaveVT. > > This is only a real leak in case of a server reset, otherwise the server > process will exit anyway and the kernel will clean up the FB. Your reasoning is sound and the new location of leave_vt did not scare me... Thanks, pushed. I'm not too concerned over simply warning about an unfixable leak along the anomalous path, though the debug spew in the kernel for this error is not as obvious as I'd like. -Chris -- Chris Wilson, Intel Open Source Technology Centre