From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 18/22] drm/amdgpu: Correct sdma_v4 get_wptr Date: Mon, 26 Feb 2018 11:22:06 +0100 Message-ID: References: <1519622300-8990-1-git-send-email-Monk.Liu@amd.com> <1519622300-8990-19-git-send-email-Monk.Liu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1519622300-8990-19-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Monk Liu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Emily Deng QW0gMjYuMDIuMjAxOCB1bSAwNjoxOCBzY2hyaWViIE1vbmsgTGl1Ogo+IEZyb206IEVtaWx5IERl bmcgPEVtaWx5LkRlbmdAYW1kLmNvbT4KPgo+IHRoZSBvcmlnaW5hbCBtZXRob2Qgd2lsbCBjaGFu Z2UgdGhlIHdwdHIgdmFsdWUgaW4gd2IuCj4KPiBDaGFuZ2UtSWQ6IEk5ODRmYWJjYTM1ZDlkY2Yx ZjVmYThlZjc3NzliMmFmYjdmN2Q3MzcwCj4gU2lnbmVkLW9mZi1ieTogRW1pbHkgRGVuZyA8RW1p bHkuRGVuZ0BhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2Rt YV92NF8wLmMgfCAxMCArKysrKy0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspLCA1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L3NkbWFfdjRfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvc2RtYV92NF8w LmMKPiBpbmRleCAzZDUzODVkLi44YzZlNDA4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L3NkbWFfdjRfMC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvc2RtYV92NF8wLmMKPiBAQCAtMjQwLDEzICsyNDAsMTQgQEAgc3RhdGljIHVpbnQ2NF90IHNk bWFfdjRfMF9yaW5nX2dldF93cHRyKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZykKPiAgIAlzdHJ1 Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IHJpbmctPmFkZXY7Cj4gICAJdTY0ICp3cHRyID0gTlVM TDsKPiAgIAl1aW50NjRfdCBsb2NhbF93cHRyID0gMDsKPiAtCj4gKwl1NjQgdG1wID0gMDsKClBs ZWFzZSBrZWVwIGFuIGVtcHR5IGxpbmUgYmV0d2VlbiBkZWNlbGVyYXRpb24gYW5kIGNvZGUuCgo+ ICAgCWlmIChyaW5nLT51c2VfZG9vcmJlbGwpIHsKPiAgIAkJLyogWFhYIGNoZWNrIGlmIHN3YXBw aW5nIGlzIG5lY2Vzc2FyeSBvbiBCRSAqLwo+ICAgCQl3cHRyID0gKCh1NjQgKikmYWRldi0+d2Iu d2JbcmluZy0+d3B0cl9vZmZzXSk7Cj4gICAJCURSTV9ERUJVRygid3B0ci9kb29yYmVsbCBiZWZv cmUgc2hpZnQgPT0gMHglMDE2bGx4XG4iLCAqd3B0cik7Cj4gLQkJKndwdHIgPSAoKndwdHIpID4+ IDI7Cj4gLQkJRFJNX0RFQlVHKCJ3cHRyL2Rvb3JiZWxsIGFmdGVyIHNoaWZ0ID09IDB4JTAxNmxs eFxuIiwgKndwdHIpOwo+ICsJCXRtcCA9ICgqd3B0cikgPj4gMjsKPiArCQlEUk1fREVCVUcoIndw dHIvZG9vcmJlbGwgYWZ0ZXIgc2hpZnQgPT0gMHglMDE2bGx4XG4iLCB0bXApOwo+ICsJCXJldHVy biB0bXA7CgpXZWxsIEkgY29tcGxldGVseSBhZ3JlZSB0aGF0IHRoaXMgY29kZSBpcyBhYnNvbHV0 ZWx5IG5vbnNlbnNlIGFuZCBjb3VsZCAKcmVzdWx0IGluIGNvbXBsZXRlIHJhbmRvbSBoYXJkd2Fy ZSBiZWhhdmlvci4KCkJ1dCBJIHRoaW5rIHdlIG5lZWQgZnVydGhlciBjbGVhbnVwIHRoYW4gd2hh dCB5b3UgYWxyZWFkeSBkaWQuIEhvdyBhYm91dCAKdGhlIGZvbGxvd2luZyBpbnN0ZWFkPwoKPiBz dGF0aWMgdWludDY0X3Qgc2RtYV92NF8wX3JpbmdfZ2V0X3dwdHIoc3RydWN0IGFtZGdwdV9yaW5n ICpyaW5nKQo+IHsKPiDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9 IHJpbmctPmFkZXY7Cj4gwqDCoMKgwqDCoMKgwqAgdWludDY0X3Qgd3B0cjsKPgo+IMKgwqDCoMKg wqDCoMKgIGlmIChyaW5nLT51c2VfZG9vcmJlbGwpIHsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgLyogWFhYIGNoZWNrIGlmIHN3YXBwaW5nIGlzIG5lY2Vzc2FyeSBvbiBCRSAqLwo+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB3cHRyID0gUkVBRF9PTkNFKCooKHU2NCAq KSZhZGV2LT53Yi53YltyaW5nLT53cHRyX29mZnNdKSk7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIERSTV9ERUJVRygid3B0ci9kb29yYmVsbCA9PSAweCUwMTZsbHhcbiIsICp3cHRy KTsKPiDCoMKgwqDCoMKgwqDCoCB9IGVsc2Ugewo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBpbnQgbWUgPSAocmluZyA9PSAmYWRldi0+c2RtYS5pbnN0YW5jZVswXS5yaW5nKSA/IDAg OiAxOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1MzIgbG93Yml0LCBoaWdoYml0 Owo+Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGxvd2JpdCA9IFJSRUczMihzZG1h X3Y0XzBfZ2V0X3JlZ19vZmZzZXQoYWRldiwgbWUsIAo+IG1tU0RNQTBfR0ZYX1JCX1dQVFIpKTsK PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGlnaGJpdCA9IFJSRUczMihzZG1hX3Y0 XzBfZ2V0X3JlZ19vZmZzZXQoYWRldiwgbWUsIAo+IG1tU0RNQTBfR0ZYX1JCX1dQVFJfSEkpKTsK Pgo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBEUk1fREVCVUcoIndwdHIgWyVpXWhp Z2g9PSAweCUwOHggbG93PT0weCUwOHhcbiIsCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbWUsIGhpZ2hiaXQsIGxvd2JpdCk7 Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHdwdHIgPSBoaWdoYml0Owo+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB3cHRyID0gd3B0ciA8PCAzMjsKPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgd3B0ciB8PSBsb3diaXQ7Cj4gwqDCoMKgwqDCoMKgwqAgfQo+ Cj4gwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHdwdHIgPj4gMjsKPiB9CgpHb29kIGNhdGNoLApDaHJp c3RpYW4uCgo+ICAgCX0gZWxzZSB7Cj4gICAJCXUzMiBsb3diaXQsIGhpZ2hiaXQ7Cj4gICAJCWlu dCBtZSA9IChyaW5nID09ICZhZGV2LT5zZG1hLmluc3RhbmNlWzBdLnJpbmcpID8gMCA6IDE7Cj4g QEAgLTI2MCw5ICsyNjEsOCBAQCBzdGF0aWMgdWludDY0X3Qgc2RtYV92NF8wX3JpbmdfZ2V0X3dw dHIoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nKQo+ICAgCQkqd3B0ciA9IGhpZ2hiaXQ7Cj4gICAJ CSp3cHRyID0gKCp3cHRyKSA8PCAzMjsKPiAgIAkJKndwdHIgfD0gbG93Yml0Owo+ICsJCXJldHVy biAqd3B0cjsKPiAgIAl9Cj4gLQo+IC0JcmV0dXJuICp3cHRyOwo+ICAgfQo+ICAgCj4gICAvKioK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZngg bWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=