Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1341DC433E0 for ; Fri, 22 May 2020 14:11:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0E9922226 for ; Fri, 22 May 2020 14:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0E9922226 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jc84p-0008GB-Ga; Fri, 22 May 2020 13:51:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jc84o-0008G6-10 for xen-devel@lists.xenproject.org; Fri, 22 May 2020 13:51:06 +0000 X-Inumbo-ID: 47bc7a0c-9c33-11ea-ae69-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 47bc7a0c-9c33-11ea-ae69-bc764e2007e4; Fri, 22 May 2020 13:51:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 00F20B00E; Fri, 22 May 2020 13:51:06 +0000 (UTC) Subject: Re: [PATCH v2] x86/traps: Rework #PF[Rsvd] bit handling To: Andrew Cooper References: <20200518153820.18170-1-andrew.cooper3@citrix.com> <20200521154306.29019-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 22 May 2020 15:51:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200521154306.29019-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 21.05.2020 17:43, Andrew Cooper wrote: > @@ -1439,6 +1418,21 @@ void do_page_fault(struct cpu_user_regs *regs) > if ( unlikely(fixup_page_fault(addr, regs) != 0) ) > return; > > + /* > + * Xen doesn't have reserved bits set in its pagetables, nor do we permit > + * PV guests to write any. Such entries would generally be vulnerable to > + * the L1TF sidechannel. > + * > + * The shadow pagetable logic may use reserved bits as part of > + * SHOPT_FAST_FAULT_PATH. Pagefaults arising from these will be resolved > + * via the fixup_page_fault() path. > + * > + * Anything remaining is an error, constituting corruption of the > + * pagetables and probably an L1TF vulnerable gadget. > + */ > + if ( error_code & PFEC_reserved_bit ) > + goto fatal; > + > if ( unlikely(!guest_mode(regs)) ) > { > enum pf_type pf_type = spurious_page_fault(addr, regs); > @@ -1457,13 +1451,12 @@ void do_page_fault(struct cpu_user_regs *regs) > if ( likely((fixup = search_exception_table(regs)) != 0) ) While I continue to not fully agree with not trying to fix up such faults if the fault location has recovery code attached, I realize that we're not going to reach agreement here, so somewhat hesitantly Acked-by: Jan Beulich Jan